Bug 154880 - iOS EWS is broken
Summary: iOS EWS is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Critical
Assignee: Dean Johnson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 15:14 PST by Dean Johnson
Modified: 2016-03-24 17:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2016-03-01 15:23 PST, Dean Johnson 		no flags Details | Formatted Diff | Diff
Patch (1.20 KB, patch)
2016-03-01 15:32 PST, Dean Johnson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2016-03-01 15:14:05 PST 
It looks like https://bugs.webkit.org/show_bug.cgi?id=154821 broke iOS EWS. The fix is adding back `willUseIOSDeviceSDK()` since that pops --sdk off of the argument list.
Comment 1 Dean Johnson 2016-03-01 15:23:39 PST 
Created attachment 272596 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2016-03-01 15:24:47 PST 
Comment on attachment 272596 [details]
Patch

r=me
Comment 3 David Kilzer (:ddkilzer) 2016-03-01 15:26:44 PST 
Comment on attachment 272596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272596&action=review

r-

> Tools/Scripts/copy-webkitlibraries-to-product-directory:41
> +willUseIOSDeviceSDK()

Need semi-colon.  Perl doesn't roll like python.  :)
Comment 4 Dean Johnson 2016-03-01 15:32:43 PST 
Created attachment 272598 [details]
Patch
Comment 5 WebKit Commit Bot 2016-03-01 17:42:55 PST 
Comment on attachment 272598 [details]
Patch

Clearing flags on attachment: 272598

Committed r197430: <http://trac.webkit.org/changeset/197430>
Comment 6 WebKit Commit Bot 2016-03-01 17:42:59 PST 
All reviewed patches have been landed.  Closing bug.