Bug 154878 - Timer alignment in separate web processes should not all sync up to the same point.
Summary: Timer alignment in separate web processes should not all sync up to the same ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 14:17 PST by Gavin Barraclough
Modified: 2016-03-01 15:33 PST (History)
1 user (show)

See Also:

Attachments
Fix (2.28 KB, patch)
2016-03-01 14:33 PST, Gavin Barraclough 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-03-01 14:17:44 PST 
This leads to a thundering herd of timers firing concurrently.
Comment 1 Gavin Barraclough 2016-03-01 14:33:08 PST 
Created attachment 272592 [details]
Fix
Comment 2 Chris Dumez 2016-03-01 15:05:07 PST 
Comment on attachment 272592 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=272592&action=review

r=me

> Source/WebCore/page/DOMTimer.cpp:430
> +        static double randomizedAlignment = randomNumber();

should probably be const.

> Source/WebCore/page/DOMTimer.cpp:431
> +        // Force alignment to randomizedAlignment fraction of the way between alignemntIntervals, e.g.

typo: alignemntIntervals
Comment 3 Gavin Barraclough 2016-03-01 15:33:32 PST 
Transmitting file data ..
Committed revision 197415.