Bug 154873 - [ES6] Implement Proxy.[[PreventExtensions]]
Summary: [ES6] Implement Proxy.[[PreventExtensions]]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 13:41 PST by Saam Barati
Modified: 2016-03-01 15:59 PST (History)
10 users (show)

See Also:

Attachments
patch (12.50 KB, patch)
2016-03-01 15:14 PST, Saam Barati 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-01 13:41:12 PST 
...
Comment 1 Saam Barati 2016-03-01 15:14:11 PST 
Created attachment 272595 [details]
patch
Comment 2 Oliver Hunt 2016-03-01 15:23:46 PST 
Comment on attachment 272595 [details]
patch

I do so wish these methods could actually be in JS as well (just because the error handling is more complex than is pleasant to read)
Comment 3 Saam Barati 2016-03-01 15:38:44 PST 
(In reply to comment #2)
> Comment on attachment 272595 [details]
> patch
> 
> I do so wish these methods could actually be in JS as well (just because the
> error handling is more complex than is pleasant to read)

I agree.
I was speaking with Yusuke on IRC yesterday about this.
I think version 2 implementation of Proxy will be written
in JS + implement necessary intrinsics to make it work.
Comment 4 Saam Barati 2016-03-01 15:42:48 PST 
landed in:
http://trac.webkit.org/changeset/197418
Comment 5 Saam Barati 2016-03-01 15:59:01 PST 
landed follow up to uncomment commented-out test cases in:
http://trac.webkit.org/changeset/197422