RESOLVED FIXED154862
Promise.prototype.then should use Symbol.species to construct the return Promise 
https://bugs.webkit.org/show_bug.cgi?id=154862
Summary Promise.prototype.then should use Symbol.species to construct the return Promise
Keith Miller
Reported 2016-03-01 10:33:59 PST
Promise.prototype.then should use Symbol.species to construct the return Promise
Attachments
Patch (3.95 KB, patch)
2016-03-01 10:50 PST, Keith Miller 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-03-01 10:50:13 PST
Created attachment 272575 [details] Patch
Saam Barati
Comment 2 2016-03-01 16:58:20 PST
Comment on attachment 272575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272575&action=review > Source/JavaScriptCore/builtins/PromisePrototype.js:46 > + var constructor = constructor[@symbolSpecies]; Style: remove the "var" here. > Source/JavaScriptCore/builtins/PromisePrototype.js:47 > + if (constructor == null) Is this "==" instead of "===" on purpose for null/undefined case?
Keith Miller
Comment 3 2016-03-01 17:02:12 PST
Comment on attachment 272575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272575&action=review >> Source/JavaScriptCore/builtins/PromisePrototype.js:46 >> + var constructor = constructor[@symbolSpecies]; > > Style: remove the "var" here. fixed. >> Source/JavaScriptCore/builtins/PromisePrototype.js:47 >> + if (constructor == null) > > Is this "==" instead of "===" on purpose for null/undefined case? Yeah.
Keith Miller
Comment 4 2016-03-01 17:08:58 PST
Committed r197428: <http://trac.webkit.org/changeset/197428>
Note You need to log in before you can comment on or make changes to this bug.