Bug 154840 - SpeculatedType should be easier to edit
Summary: SpeculatedType should be easier to edit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 154835
  Show dependency tree / graph
 
Reported: 2016-02-29 16:13 PST by Filip Pizlo
Modified: 2016-02-29 16:39 PST (History)
5 users (show)

See Also:

Attachments
work in progress (13.32 KB, patch)
2016-02-29 16:17 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (14.92 KB, patch)
2016-02-29 16:26 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-29 16:13:48 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-29 16:17:07 PST 
Created attachment 272529 [details]
work in progress
Comment 2 Filip Pizlo 2016-02-29 16:26:37 PST 
Created attachment 272530 [details]
the patch
Comment 3 Mark Lam 2016-02-29 16:33:56 PST 
Comment on attachment 272530 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272530&action=review

r=me

> Source/JavaScriptCore/bytecode/SpeculatedType.h:90
> +static const SpeculatedType SpecBytecodeTop        = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty).

The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value.
Comment 4 Filip Pizlo 2016-02-29 16:35:49 PST 
(In reply to comment #3)
> Comment on attachment 272530 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272530&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/bytecode/SpeculatedType.h:90
> > +static const SpeculatedType SpecBytecodeTop        = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty).
> 
> The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value.

Removed!
Comment 5 Filip Pizlo 2016-02-29 16:39:35 PST 
Landed in http://trac.webkit.org/changeset/197374