RESOLVED FIXED 154840
SpeculatedType should be easier to edit 
https://bugs.webkit.org/show_bug.cgi?id=154840
Summary SpeculatedType should be easier to edit
Filip Pizlo
Reported 2016-02-29 16:13:48 PST
Patch forthcoming.
Attachments
work in progress (13.32 KB, patch)
2016-02-29 16:17 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (14.92 KB, patch)
2016-02-29 16:26 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-02-29 16:17:07 PST
Created attachment 272529 [details] work in progress
Filip Pizlo
Comment 2 2016-02-29 16:26:37 PST
Created attachment 272530 [details] the patch
Mark Lam
Comment 3 2016-02-29 16:33:56 PST
Comment on attachment 272530 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=272530&action=review r=me > Source/JavaScriptCore/bytecode/SpeculatedType.h:90 > +static const SpeculatedType SpecBytecodeTop = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty). The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value.
Filip Pizlo
Comment 4 2016-02-29 16:35:49 PST
(In reply to comment #3) > Comment on attachment 272530 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272530&action=review > > r=me > > > Source/JavaScriptCore/bytecode/SpeculatedType.h:90 > > +static const SpeculatedType SpecBytecodeTop = SpecHeapTop | SpecEmpty; // It can be any of the above, except for SpecInt52 and SpecDoubleImpureNaN. This is (SpecHeapTop | SpecEmpty). > > The comment "This is (SpecHeapTop | SpecEmpty)" now adds no value. Removed!
Filip Pizlo
Comment 5 2016-02-29 16:39:35 PST
Landed in http://trac.webkit.org/changeset/197374
Note You need to log in before you can comment on or make changes to this bug.