Bug 154839 - [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
Summary: [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-29 15:47 PST by Joanmarie Diggs (irc: joanie)
Modified: 2016-03-07 16:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.46 KB, patch)
2016-02-29 15:55 PST, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff
Patch (6.40 KB, patch)
2016-03-07 11:57 PST, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff
Patch for landing (6.26 KB, patch)
2016-03-07 15:02 PST, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2016-02-29 15:47:44 PST
It fails for a couple of reasons:
1. Misleading indentation (https://github.com/EricssonResearch/openwebrtc/pull/580)
2. Not an integer constant expression (https://bugzilla.gnome.org/show_bug.cgi?id=761119)
Comment 1 Joanmarie Diggs (irc: joanie) 2016-02-29 15:55:34 PST
Created attachment 272526 [details]
Patch
Comment 2 Michael Catanzaro 2016-02-29 16:17:18 PST
Comment on attachment 272526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272526&action=review

> Tools/gtk/jhbuild.modules:463
>         <makeargs value="CFLAGS+=-Wno-error"/>

Instead of adding two patches, let's just remove the condition here so that we use -Wno-error always. Otherwise we're just going to need to patch this again due to whatever new compiler warning GCC or Clang introduces next year.
Comment 3 Michael Catanzaro 2016-02-29 16:40:06 PST
Actually, nowadays jhbuild passes -Wno-error to every module automatically, we can maybe just upgrade jhbuild. Joanie, since you have F24 already, want to test?

In Tools/jhbuild/jhbuild-wrapper, just change the jhbuild_revision line to something new (here I pick the latest commit, it might work) and remove the obsolete comment:

jhbuild_revision = '7a8490efbf497d04cfc244a2af0fc7361ad8dd17'

Then you can get rid of the manual -Wno-error passing in jhbuild.modules.
Comment 4 Joanmarie Diggs (irc: joanie) 2016-03-07 11:57:40 PST
Created attachment 273200 [details]
Patch
Comment 5 Michael Catanzaro 2016-03-07 13:29:43 PST
Comment on attachment 273200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273200&action=review

> Tools/gtk/jhbuild-webrtc.modules:57
> +      <makeargs value="OBJCFLAGS+=-Wno-error"/>

Ah, I didn't realize GStreamer depends on Objective C on Mac... in that case, you can get rid of these and set in in jhbuildrc like you did CFLAGS and CXXFLAGS. Probably with a comment to indicate the GStreamer dependency, else someone is liable to remove it cleaning up in the future.

> Tools/gtk/jhbuildrc:39
> +# Motivated by build failures when building dependencies with GCC 6.0.

I wouldn't leave this comment as it's not really related to any particular version of GCC; any new compiler will add new warnings, and if we use -Werror then that will cause the build to fail unnecessarily, it's clear enough we don't want that to happen.
Comment 6 Joanmarie Diggs (irc: joanie) 2016-03-07 15:02:11 PST
Created attachment 273220 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-03-07 16:04:35 PST
Comment on attachment 273220 [details]
Patch for landing

Clearing flags on attachment: 273220

Committed r197713: <http://trac.webkit.org/changeset/197713>
Comment 8 WebKit Commit Bot 2016-03-07 16:04:39 PST
All reviewed patches have been landed.  Closing bug.