Bug 154836 - Make it cheap to #include "JITOperations.h"
Summary: Make it cheap to #include "JITOperations.h"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 154835
  Show dependency tree / graph
 
Reported: 2016-02-29 13:49 PST by Filip Pizlo
Modified: 2016-02-29 16:15 PST (History)
5 users (show)

See Also:

Attachments
the patch (12.38 KB, patch)
2016-02-29 13:53 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-29 13:49:16 PST 
The header includes the whole world even though it doesn't have any definitions.  Almost all of the includes could be turned into forward declarations.
Comment 1 Filip Pizlo 2016-02-29 13:53:40 PST 
Created attachment 272516 [details]
the patch
Comment 2 Mark Lam 2016-02-29 13:55:44 PST 
Comment on attachment 272516 [details]
the patch

r=me
Comment 3 Filip Pizlo 2016-02-29 14:01:20 PST 
I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be Project not Private.  That might make some Mac builds sad.
Comment 4 Mark Lam 2016-02-29 14:03:37 PST 
(In reply to comment #3)
> I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be
> Project not Private.  That might make some Mac builds sad.

Hmmm, I forgot: new a header file probably means that you'll have to update the VC++ project files as well.
Comment 5 Filip Pizlo 2016-02-29 14:10:42 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > I will wait for EWS.  I made the bet that SlowPathThingyThing.h can be
> > Project not Private.  That might make some Mac builds sad.
> 
> Hmmm, I forgot: new a header file probably means that you'll have to update
> the VC++ project files as well.

Oh, I didn't know that!  I'll fix it.
Comment 6 Filip Pizlo 2016-02-29 14:12:31 PST 
OK, landing.
Comment 7 Filip Pizlo 2016-02-29 14:15:10 PST 
Lnaded in http://trac.webkit.org/changeset/197365