RESOLVED FIXED 154836
Make it cheap to #include "JITOperations.h" 
https://bugs.webkit.org/show_bug.cgi?id=154836
Summary Make it cheap to #include "JITOperations.h"
Filip Pizlo
Reported 2016-02-29 13:49:16 PST
The header includes the whole world even though it doesn't have any definitions. Almost all of the includes could be turned into forward declarations.
Attachments
the patch (12.38 KB, patch)
2016-02-29 13:53 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-02-29 13:53:40 PST
Created attachment 272516 [details] the patch
Mark Lam
Comment 2 2016-02-29 13:55:44 PST
Comment on attachment 272516 [details] the patch r=me
Filip Pizlo
Comment 3 2016-02-29 14:01:20 PST
I will wait for EWS. I made the bet that SlowPathThingyThing.h can be Project not Private. That might make some Mac builds sad.
Mark Lam
Comment 4 2016-02-29 14:03:37 PST
(In reply to comment #3) > I will wait for EWS. I made the bet that SlowPathThingyThing.h can be > Project not Private. That might make some Mac builds sad. Hmmm, I forgot: new a header file probably means that you'll have to update the VC++ project files as well.
Filip Pizlo
Comment 5 2016-02-29 14:10:42 PST
(In reply to comment #4) > (In reply to comment #3) > > I will wait for EWS. I made the bet that SlowPathThingyThing.h can be > > Project not Private. That might make some Mac builds sad. > > Hmmm, I forgot: new a header file probably means that you'll have to update > the VC++ project files as well. Oh, I didn't know that! I'll fix it.
Filip Pizlo
Comment 6 2016-02-29 14:12:31 PST
OK, landing.
Filip Pizlo
Comment 7 2016-02-29 14:15:10 PST
Lnaded in http://trac.webkit.org/changeset/197365
Note You need to log in before you can comment on or make changes to this bug.