Bug 154824 - Use WTF::Optional for HTMLOListElement::m_start
Summary: Use WTF::Optional for HTMLOListElement::m_start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-29 10:37 PST by Chris Dumez
Modified: 2016-02-29 16:32 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2016-02-29 10:38 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.16 KB, patch)
2016-02-29 10:39 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-29 10:37:41 PST
Use WTF::Optional for HTMLOListElement::m_start
Comment 1 Chris Dumez 2016-02-29 10:38:58 PST
Created attachment 272500 [details]
Patch
Comment 2 Chris Dumez 2016-02-29 10:39:52 PST
Created attachment 272501 [details]
Patch
Comment 3 Andreas Kling 2016-02-29 12:43:20 PST
Comment on attachment 272501 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2016-02-29 13:32:20 PST
Comment on attachment 272501 [details]
Patch

Clearing flags on attachment: 272501

Committed r197364: <http://trac.webkit.org/changeset/197364>
Comment 5 WebKit Commit Bot 2016-02-29 13:32:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2016-02-29 16:10:53 PST
Now we just have to change those parseHTML functions to return an Optional<> rather than returning a boolean and using an out argument for the parsed values.
Comment 7 Chris Dumez 2016-02-29 16:32:32 PST
(In reply to comment #6)
> Now we just have to change those parseHTML functions to return an Optional<>
> rather than returning a boolean and using an out argument for the parsed
> values.

Ah, that sounds good indeed :)