RESOLVED FIXED 154824
Use WTF::Optional for HTMLOListElement::m_start 
https://bugs.webkit.org/show_bug.cgi?id=154824
Summary Use WTF::Optional for HTMLOListElement::m_start
Chris Dumez
Reported 2016-02-29 10:37:41 PST
Use WTF::Optional for HTMLOListElement::m_start
Attachments
Patch (3.22 KB, patch)
2016-02-29 10:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.16 KB, patch)
2016-02-29 10:39 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-29 10:38:58 PST
Created attachment 272500 [details] Patch
Chris Dumez
Comment 2 2016-02-29 10:39:52 PST
Created attachment 272501 [details] Patch
Andreas Kling
Comment 3 2016-02-29 12:43:20 PST
Comment on attachment 272501 [details] Patch r=me
WebKit Commit Bot
Comment 4 2016-02-29 13:32:20 PST
Comment on attachment 272501 [details] Patch Clearing flags on attachment: 272501 Committed r197364: <http://trac.webkit.org/changeset/197364>
WebKit Commit Bot
Comment 5 2016-02-29 13:32:25 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2016-02-29 16:10:53 PST
Now we just have to change those parseHTML functions to return an Optional<> rather than returning a boolean and using an out argument for the parsed values.
Chris Dumez
Comment 7 2016-02-29 16:32:32 PST
(In reply to comment #6) > Now we just have to change those parseHTML functions to return an Optional<> > rather than returning a boolean and using an out argument for the parsed > values. Ah, that sounds good indeed :)
Note You need to log in before you can comment on or make changes to this bug.