Bug 154809 - Web Inspector: Add direct number inputs to Bezier editor
Summary: Web Inspector: Add direct number inputs to Bezier editor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-28 22:12 PST by Devin Rousso
Modified: 2016-02-29 15:50 PST (History)
8 users (show)

See Also:


Attachments
Patch (21.59 KB, patch)
2016-02-28 22:22 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
After patch is applied (66.27 KB, image/png)
2016-02-29 11:46 PST, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-02-28 22:12:08 PST
Suggested in <https://bugs.webkit.org/show_bug.cgi?id=154739#c0>.
Comment 1 Radar WebKit Bug Importer 2016-02-28 22:12:34 PST
<rdar://problem/24881465>
Comment 2 Devin Rousso 2016-02-28 22:22:10 PST
Created attachment 272475 [details]
Patch
Comment 3 Devin Rousso 2016-02-29 11:46:46 PST
Created attachment 272508 [details]
After patch is applied

Whoops.  Forgot to upload this :)
Comment 4 Timothy Hatcher 2016-02-29 14:18:26 PST
Comment on attachment 272475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272475&action=review

> Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117
> +    background-color: white;
> +    border: 1px solid hsl(0, 0%, 60%);
> +    border-radius: 4px;
> +    box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);

Why the special appearance? Why was the default not good?
Comment 5 WebKit Commit Bot 2016-02-29 15:06:51 PST
Comment on attachment 272475 [details]
Patch

Clearing flags on attachment: 272475

Committed r197371: <http://trac.webkit.org/changeset/197371>
Comment 6 WebKit Commit Bot 2016-02-29 15:06:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Devin Rousso 2016-02-29 15:50:49 PST
(In reply to comment #4)
> Comment on attachment 272475 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272475&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117
> > +    background-color: white;
> > +    border: 1px solid hsl(0, 0%, 60%);
> > +    border-radius: 4px;
> > +    box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);
> 
> Why the special appearance? Why was the default not good?

I was mimicking the appearance of the angle input in the Gradient editor.  Also, I personally like rounded borders :P