Bug 154809 – Web Inspector: Add direct number inputs to Bezier editor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Suggested in <https://bugs.webkit.org/show_bug.cgi?id=154739#c0>.

[Radar WebKit Bug Importer]

<rdar://problem/24881465>

[Devin Rousso]

Created attachment 272475 [details]
Patch

[Devin Rousso]

Created attachment 272508 [details]
After patch is applied

Whoops.  Forgot to upload this :)

[Timothy Hatcher]

Comment on attachment 272475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272475&action=review

> Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117
> +    background-color: white;
> +    border: 1px solid hsl(0, 0%, 60%);
> +    border-radius: 4px;
> +    box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);

Why the special appearance? Why was the default not good?

[WebKit Commit Bot]

Comment on attachment 272475 [details]
Patch

Clearing flags on attachment: 272475

Committed r197371: <http://trac.webkit.org/changeset/197371>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Devin Rousso]

(In reply to comment #4)
> Comment on attachment 272475 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272475&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:117
> > +    background-color: white;
> > +    border: 1px solid hsl(0, 0%, 60%);
> > +    border-radius: 4px;
> > +    box-shadow: inset 0 0 1px 1px hsl(0, 0%, 89%);
> 
> Why the special appearance? Why was the default not good?

I was mimicking the appearance of the angle input in the Gradient editor.  Also, I personally like rounded borders :P