RESOLVED FIXED 154802
Parse HTMLOLElement.start as per the HTML spec 
https://bugs.webkit.org/show_bug.cgi?id=154802
Summary Parse HTMLOLElement.start as per the HTML spec
Attachments
Patch (7.70 KB, patch)
2016-02-28 15:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-28 15:04:28 PST
Created attachment 272467 [details] Patch
Andreas Kling
Comment 2 2016-02-28 19:47:23 PST
Comment on attachment 272467 [details] Patch r=me
WebKit Commit Bot
Comment 3 2016-02-28 20:36:00 PST
Comment on attachment 272467 [details] Patch Clearing flags on attachment: 272467 Committed r197307: <http://trac.webkit.org/changeset/197307>
WebKit Commit Bot
Comment 4 2016-02-28 20:36:08 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2016-02-29 08:47:50 PST
What in the world is that 0xBADBEEF thing about?
Chris Dumez
Comment 6 2016-02-29 09:14:40 PST
(In reply to comment #5) > What in the world is that 0xBADBEEF thing about? We only read m_start if m_hasExplicitStart is true. If m_hasExplicitStart is false, we set m_start to 0xBADBEEF to make it clear its value is invalid. Honestly, I feel this should be refactored to use WTF::Optional<>. I'll probably do this in a follow-up.
Note You need to log in before you can comment on or make changes to this bug.