154802 – Parse HTMLOLElement.start as per the HTML spec

Bug 154802 - Parse HTMLOLElement.start as per the HTML spec

Summary: Parse HTMLOLElement.start as per the HTML spec

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	DOM (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Chris Dumez

URL:
Keywords:	WebExposed

Depends on:
Blocks:

Reported:	2016-02-28 15:00 PST by Chris Dumez
Modified:	2016-02-29 09:14 PST (History)
CC List:	6 users (show)

See Also:

Attachments
Patch (7.70 KB, patch) 2016-02-28 15:04 PST, Chris Dumez	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Dumez 2016-02-28 15:00:41 PST

Parse HTMLOLElement.start as per the HTML spec:
- https://html.spec.whatwg.org/multipage/semantics.html#dom-ol-start
- https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-integers

Comment 1 Chris Dumez 2016-02-28 15:04:28 PST

Created attachment 272467 [details]
Patch

Comment 2 Andreas Kling 2016-02-28 19:47:23 PST

Comment on attachment 272467 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2016-02-28 20:36:00 PST

Comment on attachment 272467 [details]
Patch

Clearing flags on attachment: 272467

Committed r197307: <http://trac.webkit.org/changeset/197307>

Comment 4 WebKit Commit Bot 2016-02-28 20:36:08 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Darin Adler 2016-02-29 08:47:50 PST

What in the world is that 0xBADBEEF thing about?

Comment 6 Chris Dumez 2016-02-29 09:14:40 PST

(In reply to comment #5)
> What in the world is that 0xBADBEEF thing about?

We only read m_start if m_hasExplicitStart is true. If m_hasExplicitStart is false, we set m_start to 0xBADBEEF to make it clear its value is invalid. Honestly, I feel this should be refactored to use WTF::Optional<>. I'll probably do this in a follow-up.