Bug 15480 - SVG requiredFeatures broken
: SVG requiredFeatures broken
Status: RESOLVED FIXED
: WebKit
SVG
: 523.x (Safari 3)
: Macintosh Mac OS X 10.4
: P2 Normal
Assigned To:
:
: HasReduction
:
:
  Show dependency treegraph
 
Reported: 2007-10-12 14:33 PST by
Modified: 2007-12-27 01:33 PST (History)


Attachments
test for static support (9.89 KB, image/svg+xml)
2007-10-12 14:34 PST, jay
no flags Details
Patch to make our feature strings match reality (4.26 KB, patch)
2007-12-19 03:41 PST, Eric Seidel
no flags Review Patch | Details | Formatted Diff | Diff
Stop claiming to support SVG feature strings we don't (14.53 KB, patch)
2007-12-20 03:54 PST, Eric Seidel
zimmermann: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2007-10-12 14:33:34 PST
requiredFeatures combined with switch provides a relatively easy way for the author to create workarounds.

but not if it isn't supported....
------- Comment #1 From 2007-10-12 14:34:14 PST -------
Created an attachment (id=16644) [details]
test for static support
------- Comment #2 From 2007-10-12 14:37:31 PST -------
the attachment renders as "RDF"

however as static requires all features to be supported and font is not supported the result should be "3"
as per mozilla... 
opera does support font and displays the glyph for background of the new SVG logo
------- Comment #3 From 2007-10-14 00:56:32 PST -------
Interesting.  This shows two bugs.  1.  We shouldn't be claiming to support "static" when we don't support fonts.  2.  We are rendering the contents of <title> elements, which we should not do.
------- Comment #4 From 2007-11-05 18:17:50 PST -------
Ah!  We're not rendering <title> elements, it's being used by a tref.  So the only bug here is that hasFeature reports too many features for WebKit (since we don't support SVG fonts).
------- Comment #5 From 2007-12-19 03:41:27 PST -------
Created an attachment (id=17986) [details]
Patch to make our feature strings match reality

This patch should make our feature strings match reality.  I've not yet run the layout tests to get an updated patch for those yet.
------- Comment #6 From 2007-12-19 03:51:15 PST -------
Of course whenever Niko's font patch lands, we'll have to re-enable a bunch of these strings again!
------- Comment #7 From 2007-12-20 03:54:00 PST -------
Created an attachment (id=18004) [details]
Stop claiming to support SVG feature strings we don't

 LayoutTests/ChangeLog                              |   16 +++++++
 .../W3C-SVG-1.1/struct-cond-03-t-expected.checksum |    2 +-
 .../svg/W3C-SVG-1.1/struct-cond-03-t-expected.png  |  Bin 12813 -> 7287 bytes
 .../svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt  |   10 +----
 .../struct-image-02-b-expected.checksum            |    2 +-
 .../svg/W3C-SVG-1.1/struct-image-02-b-expected.png |  Bin 50516 -> 50517 bytes
 .../svg/W3C-SVG-1.1/struct-image-02-b-expected.txt |    9 ++--
 LayoutTests/svg/custom/svg-features-expected.txt   |   26 ++++++------
 WebCore/ChangeLog                                  |   11 +++++
 WebCore/dom/DOMImplementation.cpp                  |   44 +++++++++++--------
 10 files changed, 73 insertions(+), 47 deletions(-)
------- Comment #8 From 2007-12-20 06:27:09 PST -------
(From update of attachment 18004 [details])
Good work, r=me.
Hopefully we can reeanble some soon....
------- Comment #9 From 2007-12-27 01:33:05 PST -------
Landed as r28891.