Bug 154799 - [[IsExtensible]] should be a virtual method in the method table
Summary: [[IsExtensible]] should be a virtual method in the method table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-28 13:16 PST by Saam Barati
Modified: 2016-03-01 13:45 PST (History)
10 users (show)

See Also:

Attachments
WIP (18.46 KB, patch)
2016-03-01 01:08 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (21.46 KB, patch)
2016-03-01 12:24 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (21.94 KB, patch)
2016-03-01 12:29 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-02-28 13:16:35 PST 
This will make us more consistent with the specification and is necessary for proxies.
Comment 1 Saam Barati 2016-03-01 01:08:16 PST 
Created attachment 272554 [details]
WIP

This is almost done. I just need to audit some call sites of the previous isExtensible().
Comment 2 Saam Barati 2016-03-01 12:24:09 PST 
Created attachment 272584 [details]
patch
Comment 3 Saam Barati 2016-03-01 12:29:31 PST 
Created attachment 272585 [details]
patch
Comment 4 Mark Lam 2016-03-01 12:43:49 PST 
Comment on attachment 272585 [details]
patch

r=me

Do we already tests that exercises the [[IsExtensible]] check?  If not, can we add some?
Comment 5 Saam Barati 2016-03-01 13:33:51 PST 
(In reply to comment #4)
> Comment on attachment 272585 [details]
> patch
> 
> r=me
> 
> Do we already tests that exercises the [[IsExtensible]] check?  If not, can
> we add some?

Thanks for the review.
We already have tests. I'll also be adding more as I work on Proxy.[[IsExtensible]]/Proxy.[[PreventExtensions]]
Comment 6 Saam Barati 2016-03-01 13:45:28 PST 
landed in:
http://trac.webkit.org/changeset/197412