Bug 15479 - SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
Summary: SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-12 13:13 PDT by Eric Seidel (no email)
Modified: 2011-05-12 11:34 PDT (History)
2 users (show)

See Also:


Attachments
Remove resolveStyle (2.04 KB, patch)
2011-05-12 11:21 PDT, Rob Buis
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-12 13:13:29 PDT
SVGStyledElement::resolveStyle(RenderStyle*) must be removed!

It shouldn't be necessary now that we have (and use) RenderSVGHiddenContainer (to hold style across things like <defs>).  If a filter element doesn't otherwise have style in those cases than it probably isn't "valid" SVG and shouldn't be rendered.

It is *possible* that this method may need to exist (to force a manual style resolve for a display:none SVG tree or the like) but in that case it needs to be improved (to walk the whole parent chain instead of the current only check the parent).
Comment 1 Rob Buis 2011-05-12 11:21:50 PDT
Created attachment 93312 [details]
Remove resolveStyle
Comment 2 Rob Buis 2011-05-12 11:34:40 PDT
Committed r86365: <http://trac.webkit.org/changeset/86365>