Bug 154783 - REGRESSION (r192252): Allow display: none on -webkit-media-controls
Summary: REGRESSION (r192252): Allow display: none on -webkit-media-controls
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-27 17:30 PST by zalan
Modified: 2016-05-06 10:54 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.66 KB, patch)
2016-02-27 18:18 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.69 KB, patch)
2016-02-27 18:19 PST, zalan 		simon.fraser: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-02-27 17:30:15 PST 
rdar://problem/24245117
Comment 1 zalan 2016-02-27 18:18:42 PST 
Created attachment 272430 [details]
Patch
Comment 2 zalan 2016-02-27 18:19:42 PST 
Created attachment 272431 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-27 18:20:27 PST 
Attachment 272431 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleResolver.cpp:844:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2016-02-28 20:22:46 PST 
Comment on attachment 272431 [details]
Patch

That's what the 'controls' attribute is for. Authors should not be messing with -webkit-media-controls
Comment 6 zalan 2016-02-28 20:26:22 PST 
While I agree with "Authors should not be messing with -webkit-media-controls", it is a valid workaround as long as we don't have that full-screen issue fixed.