Bug 15478 - Declare vars and functions iteratively upon entering an execution context
Summary: Declare vars and functions iteratively upon entering an execution context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 14868
  Show dependency treegraph
 
Reported: 2007-10-12 12:35 PDT by Geoffrey Garen
Modified: 2007-10-18 16:48 PDT (History)
1 user (show)

See Also:


Attachments
Patch (35.16 KB, patch)
2007-10-12 12:35 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch2 (42.33 KB, patch)
2007-10-12 13:05 PDT, Geoffrey Garen
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2007-10-12 12:35:11 PDT
Broken off from bug 14868.
Comment 1 Geoffrey Garen 2007-10-12 12:35:24 PDT
Created attachment 16642 [details]
Patch
Comment 2 Geoffrey Garen 2007-10-12 13:05:11 PDT
Created attachment 16643 [details]
Patch2

Added some layout tests to the patch.
Comment 3 Maciej Stachowiak 2007-10-13 18:30:33 PDT
Comment on attachment 16643 [details]
Patch2

r=me

Don't forget to add a ChangeLog.

One other comment: you use i++ as the increment in some for loops, I would mildly suggest changing it to ++i. Preincrement vs. postincrement doesn't matter for integers, but it is more efficient for iterators and it is nicer to consistently use that style instead of only when needed.
Comment 4 Geoffrey Garen 2007-10-16 14:46:11 PDT
Added ChangeLog. Changed some i++ to ++i.

Committed revision 26682.