RESOLVED FIXED 154772
Optimize parseHTMLInteger() 
https://bugs.webkit.org/show_bug.cgi?id=154772
Summary Optimize parseHTMLInteger()
Chris Dumez
Reported 2016-02-26 21:43:16 PST
Optimize parseHTMLInteger() now that it is used a lot more and that it has decent API test coverage.
Attachments
Patch (3.80 KB, patch)
2016-02-26 21:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.12 KB, patch)
2016-02-26 22:34 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.12 KB, patch)
2016-02-27 09:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-26 21:53:55 PST
Created attachment 272400 [details] Patch
Ryosuke Niwa
Comment 2 2016-02-26 22:04:10 PST
Comment on attachment 272400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272400&action=review > Source/WebCore/html/parser/HTMLParserIdioms.cpp:176 > + value = charactersToIntStrict(numberStart, position - numberStart, &ok); Can we just compute the result in the above loop instead of calling this function? We're just parsing decimal number here and we've already traversed the entire string.
Chris Dumez
Comment 3 2016-02-26 22:34:16 PST
Created attachment 272409 [details] Patch
Ryosuke Niwa
Comment 4 2016-02-26 22:49:58 PST
Comment on attachment 272409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272409&action=review > Source/WebCore/html/parser/HTMLParserIdioms.cpp:178 > + int result = 0; Why don't we use unsigned here > Source/WebCore/html/parser/HTMLParserIdioms.cpp:182 > + if (result > maxMultiplier || (result == maxMultiplier && digitValue > (intMax % base) + isNegative)) So that we can simplify the second condition here? Now that I'm seeing this code for overflow check, perhaps calling charactersToIntStrict wasn't that bad...
Chris Dumez
Comment 5 2016-02-27 09:43:13 PST
Created attachment 272418 [details] Patch
WebKit Commit Bot
Comment 6 2016-02-27 10:30:52 PST
Comment on attachment 272418 [details] Patch Clearing flags on attachment: 272418 Committed r197255: <http://trac.webkit.org/changeset/197255>
WebKit Commit Bot
Comment 7 2016-02-27 10:30:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.