Optimize parseHTMLInteger() now that it is used a lot more and that it has decent API test coverage.
Created attachment 272400 [details]
Comment on attachment 272400 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=272400&action=review
> + value = charactersToIntStrict(numberStart, position - numberStart, &ok);
Can we just compute the result in the above loop instead of calling this function?
We're just parsing decimal number here and we've already traversed the entire string.
Created attachment 272409 [details]
Comment on attachment 272409 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=272409&action=review
> + int result = 0;
Why don't we use unsigned here
> + if (result > maxMultiplier || (result == maxMultiplier && digitValue > (intMax % base) + isNegative))
So that we can simplify the second condition here?
Now that I'm seeing this code for overflow check, perhaps calling charactersToIntStrict wasn't that bad...
Created attachment 272418 [details]
Comment on attachment 272418 [details]
Clearing flags on attachment: 272418
Committed r197255: <http://trac.webkit.org/changeset/197255>
All reviewed patches have been landed. Closing bug.