Bug 154751 - Reduce direct callers of Structure::findStructuresAndMapForMaterialization
Summary: Reduce direct callers of Structure::findStructuresAndMapForMaterialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-26 14:03 PST by Joseph Pecoraro
Modified: 2016-02-26 14:58 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.27 KB, patch)
2016-02-26 14:04 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-26 14:03:25 PST 
* SUMMARY
Reduce direct callers of Structure::findStructuresAndMapForMaterialization.

Structure::findStructuresAndMapForMaterialization has a very subtle locking contract. Most places that use it, simply want to iterate over all of the properties of the structure. For that, we can use Structure::forEachPropertyConcurrently.

Here the code was identical, so just share the code.
Comment 1 Joseph Pecoraro 2016-02-26 14:04:47 PST 
Created attachment 272368 [details]
[PATCH] Proposed Fix
Comment 2 Mark Lam 2016-02-26 14:10:15 PST 
Comment on attachment 272368 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2016-02-26 14:58:48 PST 
Comment on attachment 272368 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 272368

Committed r197210: <http://trac.webkit.org/changeset/197210>
Comment 4 WebKit Commit Bot 2016-02-26 14:58:53 PST 
All reviewed patches have been landed.  Closing bug.