Bug 154750 – WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data

[Anders Carlsson]

Created attachment 272367 [details]
Patch

[WebKit Commit Bot]

Attachment 272367 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Tools/MiniBrowser/mac/WK2BrowserWindowController.m:483:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:285:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:153:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp:156:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:32:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSizeInternal.h:32:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h:78:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 272367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272367&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:134
> +    return [[_WKWebsiteDataSize alloc] initWithSize:*size];

Shouldn't it be more clear that this returns a retained thing?

[Anders Carlsson]

Committed r197203: <http://trac.webkit.org/changeset/197203>

[Sam Weinig]

Comment on attachment 272367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272367&action=review

> Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:231
> +                    callbackAggregator->m_websiteData.entries.append(WebsiteData::Entry { securityOrigin, WebsiteDataType::IndexedDBDatabases, 0 });

Does this need a FIXME? Shouldn't we be sending a size?

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:310
> +            auto result = originsAndSizes->add(SecurityOrigin::create(traversalEntry->entry.response().url()), 0);

Should I add a version of HashMap::ensure() that takes two lambdas, one for the success case, one for the failure?

> Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.mm:50
> +- (unsigned long long)sizeOfDataTypes:(NSSet<NSString *> *)dataTypes

This will fail on Yosemite.