Bug 154747 - storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2
Summary: storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 154968
  Show dependency treegraph
 
Reported: 2016-02-26 13:39 PST by Ryan Haddad
Modified: 2016-03-03 11:46 PST (History)
5 users (show)

See Also:


Attachments
Patch v1 (3.19 KB, patch)
2016-03-03 09:58 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-02-26 13:39:54 PST
storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2

Most recent failure:
<https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r197191%20(3257)/results.html>

Flakiness dashboard:
<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fdelete-in-upgradeneeded-close-in-open-success.html>

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-actual.txt
@@ -24,15 +24,15 @@
 PASS event.newVersion is null
 sawVersionChange = true
 
-deleteBlockedCallback():
-PASS sawVersionChange is true
-sawDeleteBlocked = true
-
 openSuccess():
 PASS sawUpgradeNeeded is true
 db = event.target.result
 PASS db.version is 1
 db.close()
+
+deleteBlockedCallback():
+PASS sawVersionChange is true
+sawDeleteBlocked = true
 
 deleteSuccessCallback():
 PASS sawVersionChange is true
Comment 1 Brady Eidson 2016-03-03 09:53:38 PST
This callback coming out of order like this is okay.

Makes sense that it's WK2-only, since WK1 has a much more well defined order with the thread-hopping versus process hopping.

Easy fix to the test to make it determinate.
Comment 2 Brady Eidson 2016-03-03 09:58:11 PST
Created attachment 272760 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-03-03 11:46:16 PST
Comment on attachment 272760 [details]
Patch v1

Clearing flags on attachment: 272760

Committed r197513: <http://trac.webkit.org/changeset/197513>
Comment 4 WebKit Commit Bot 2016-03-03 11:46:20 PST
All reviewed patches have been landed.  Closing bug.