Bug 154745 - Add Proxy tests for exceptions that depend on an object being non-extensible and having configurable properties
Summary: Add Proxy tests for exceptions that depend on an object being non-extensible ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-26 13:28 PST by Saam Barati
Modified: 2019-06-10 20:07 PDT (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-02-26 13:28:23 PST 
I missed writing some of these tests because I didn't realize you could easily
make an object get into this state. But it's super easy. Object.preventExtensions
puts an object into this state.
Comment 1 Filip Pizlo 2016-03-03 21:20:56 PST 
This is referenced from this commit: http://trac.webkit.org/changeset/197539.

That suggests that maybe that commit should have referenced a different bug?
Comment 2 Saam Barati 2016-03-03 23:15:50 PST 
(In reply to comment #1)
> This is referenced from this commit: http://trac.webkit.org/changeset/197539.
> 
> That suggests that maybe that commit should have referenced a different bug?

Yeah it definitely should have. That was a mistake on my end.
Is it worth going back and editing the change log?