Bug 154744 - Page TimerAlignmentIntervalIncrease mechanism should have upper limit
Summary: Page TimerAlignmentIntervalIncrease mechanism should have upper limit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-26 13:10 PST by Gavin Barraclough
Modified: 2016-02-26 15:26 PST (History)
0 users

See Also:


Attachments
Fix (17.76 KB, patch)
2016-02-26 13:53 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-02-26 13:10:53 PST
There would be diminishing returns from throttling timers in background pages infinitely. Add a heuristic to try to limit appropriately.
Comment 1 Gavin Barraclough 2016-02-26 13:53:29 PST
Created attachment 272365 [details]
Fix
Comment 2 Geoffrey Garen 2016-02-26 14:20:15 PST
Comment on attachment 272365 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=272365&action=review

r=me

> Source/WebKit2/UIProcess/WebProcessPool.cpp:1325
> +void WebProcessPool::updateHidenPageThrottingAutoIncreaseLimit()

"hidden"

"throttling"
Comment 3 Gavin Barraclough 2016-02-26 14:41:06 PST
wow I speel gud. :-(
Comment 4 Gavin Barraclough 2016-02-26 15:26:43 PST
Transmitting file data ............
Committed revision 197213.