Bug 154735 - Modern IDB: Using existing database info from SQLite backing store is busted
Summary: Modern IDB: Using existing database info from SQLite backing store is busted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2016-02-26 10:45 PST by Brady Eidson
Modified: 2016-02-26 11:49 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (4.47 KB, patch)
2016-02-26 10:51 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-02-26 10:45:00 PST 
Modern IDB: Using existing database info from SQLite backing store is busted

Extracting the database info on the backing store thread works fine.

When we do a thread-safe copy back to the main thread, object store infos weren't copied.

Yikes.
Comment 1 Brady Eidson 2016-02-26 10:45:25 PST 
<rdar://problem/24848143>
Comment 2 Brady Eidson 2016-02-26 10:47:48 PST 
Also there was an obvious code path where we don't migrate index records from existing databases.  *sigh*
Comment 3 Brady Eidson 2016-02-26 10:51:09 PST 
Created attachment 272340 [details]
Patch v1
Comment 4 WebKit Commit Bot 2016-02-26 11:49:29 PST 
Comment on attachment 272340 [details]
Patch v1

Clearing flags on attachment: 272340

Committed r197190: <http://trac.webkit.org/changeset/197190>
Comment 5 WebKit Commit Bot 2016-02-26 11:49:34 PST 
All reviewed patches have been landed.  Closing bug.