Following on bug 154536, it might be good to refactor a bit FetchBody constructors: use the move constructor, renaming fromJSValue to extract and remove empty static method.
Created attachment 272317 [details] Patch
Comment on attachment 272317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272317&action=review > Source/WebCore/Modules/fetch/FetchBody.h:73 > + FetchBody() { } I sometimes prefer to write = default for these instead of writing out the inline empty body. > Source/WebCore/Modules/fetch/FetchResponse.cpp:53 > + return adoptRef(*new FetchResponse(Type::Error, FetchBody(), FetchHeaders::create(FetchHeaders::Guard::Immutable), ResourceResponse())); Could just use { } here instead of FetchBody(). > Source/WebCore/Modules/fetch/FetchResponse.cpp:68 > + RefPtr<FetchResponse> redirectResponse = adoptRef(*new FetchResponse(Type::Default, FetchBody(), FetchHeaders::create(FetchHeaders::Guard::Immutable), ResourceResponse())); Could just use { } here instead of FetchBody(). > Source/WebCore/Modules/fetch/FetchResponse.h:50 > + static Ref<FetchResponse> create() { return adoptRef(*new FetchResponse(Type::Default, FetchBody(), FetchHeaders::create(FetchHeaders::Guard::Response), ResourceResponse())); } Could just use { } here instead of FetchBody().
Created attachment 272478 [details] Patch
(In reply to comment #3) > Created attachment 272478 [details] > Patch Thanks for the reviews. I updated the patch with Darin's suggestions.
Comment on attachment 272478 [details] Patch Clearing flags on attachment: 272478 Committed r197347: <http://trac.webkit.org/changeset/197347>
All reviewed patches have been landed. Closing bug.