Bug 154714 – Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
- https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
- https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers

[Chris Dumez]

Created attachment 272293 [details]
Patch

[Darin Adler]

Comment on attachment 272293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272293&action=review

> Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:72
> +    // Boundaries.
> +    EXPECT_EQ(-2147483648, testParseHTMLInteger("-2147483648"));
> +    EXPECT_EQ(2147483647, testParseHTMLInteger("2147483647"));

We should include failure case tests that are just outside the boundaries: -2147483649, 2147483648. And maybe some other "too long number" tests.

> Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:74
> +    // Failure cases.

Might be good to also include expected failures that are legal floating point numbers such as "1.0", "1.", "1e1", ".1", "infinity". Some ways of implementing this might accidentally allow those.

> Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:124
> +    EXPECT_EQ(4294967295u, testParseHTMLNonNegativeInteger("4294967295"));

We should include a failure case test that is just outside the boundary: 4294967296.

> Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:126
> +    // Failure cases.

Might be good to also include expected failures that are legal floating point numbers such as "1.0", "1.", "1e1", ".1", "infinity". Some ways of implementing this might accidentally allow those.

[Chris Dumez]

Created attachment 272385 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 272385 [details]
Patch

Clearing flags on attachment: 272385

Committed r197225: <http://trac.webkit.org/changeset/197225>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.