Bug 154708 - RenderTheme::controlSize* methods should take const RenderStyle&.
Summary: RenderTheme::controlSize* methods should take const RenderStyle&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-25 18:45 PST by zalan
Modified: 2016-02-26 09:36 PST (History)
5 users (show)

See Also:


Attachments
Patch (13.59 KB, patch)
2016-02-25 18:49 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (14.90 KB, patch)
2016-02-26 09:22 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-02-25 18:45:00 PST
and not non-const.
Comment 1 zalan 2016-02-25 18:49:54 PST
Created attachment 272277 [details]
Patch
Comment 2 Darin Adler 2016-02-26 08:11:29 PST
Comment on attachment 272277 [details]
Patch

RenderThemeIOS.h:42:17: error: 'popupInternalPaddingRight' marked 'override' but does not override any member functions
    virtual int popupInternalPaddingRight(RenderStyle&) const override;
Comment 3 zalan 2016-02-26 09:22:29 PST
Created attachment 272328 [details]
Patch
Comment 4 WebKit Commit Bot 2016-02-26 09:35:58 PST
Comment on attachment 272328 [details]
Patch

Clearing flags on attachment: 272328

Committed r197170: <http://trac.webkit.org/changeset/197170>
Comment 5 WebKit Commit Bot 2016-02-26 09:36:02 PST
All reviewed patches have been landed.  Closing bug.