Bug 154706 – storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac-wk2 debug

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryan Haddad]

storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac-wk2

After <http://trac.webkit.org/changeset/197122>, this test seems to be a flaky crash on mac-wk2 debug

Most recent crash:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/3232>

Flakiness dashboard:
<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fintversion-open-in-upgradeneeded.html>

Thread 4 Crashed:: IndexedDatabase Server
0   com.apple.JavaScriptCore      	0x0000000110ae2f27 WTFCrash + 39 (Assertions.cpp:322)
1   com.apple.WebCore             	0x0000000114c75688 WebCore::SQLiteTransaction::begin() + 88 (SQLiteTransaction.cpp:53)
2   com.apple.WebCore             	0x0000000114e133de WebCore::IDBServer::SQLiteIDBTransaction::begin(WebCore::SQLiteDatabase&) + 974 (SQLiteIDBTransaction.cpp:62)
3   com.apple.WebCore             	0x0000000114c94bec WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction(WebCore::IDBTransactionInfo const&) + 1628 (SQLiteIDBBackingStore.cpp:625)
4   com.apple.WebCore             	0x0000000114fbe035 WebCore::IDBServer::UniqueIDBDatabase::beginTransactionInBackingStore(WebCore::IDBTransactionInfo const&) + 117 (UniqueIDBDatabase.cpp:374)
5   com.apple.WebCore             	0x0000000114fe6adf WebCore::CrossThreadTaskImpl<WebCore::IDBServer::UniqueIDBDatabase, WebCore::IDBTransactionInfo const&>::CrossThreadTaskImpl(WebCore::IDBServer::UniqueIDBDatabase*, void (WebCore::IDBServer::UniqueIDBDatabase::*)(WebCore::IDBTransactionInfo const&), WebCore::IDBTransactionInfo const&)::'lambda'()::operator()() const + 127 (CrossThreadTask.h:61)
6   com.apple.WebCore             	0x0000000114fe6a4d _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN7WebCore19CrossThreadTaskImplINS3_9IDBServer17UniqueIDBDatabaseEJRKNS3_18IDBTransactionInfoEEEC1EPS6_MS6_FvS9_ES9_EUlvE_EEEvDpOT_ + 45 (__functional_base:441)
7   com.apple.WebCore             	0x0000000114fe68dc std::__1::__function::__func<WebCore::CrossThreadTaskImpl<WebCore::IDBServer::UniqueIDBDatabase, WebCore::IDBTransactionInfo const&>::CrossThreadTaskImpl(WebCore::IDBServer::UniqueIDBDatabase*, void (WebCore::IDBServer::UniqueIDBDatabase::*)(WebCore::IDBTransactionInfo const&), WebCore::IDBTransactionInfo const&)::'lambda'(), std::__1::allocator<WebCore::CrossThreadTaskImpl<WebCore::IDBServer::UniqueIDBDatabase, WebCore::IDBTransactionInfo const&>::CrossThreadTaskImpl(WebCore::IDBServer::UniqueIDBDatabase*, void (WebCore::IDBServer::UniqueIDBDatabase::*)(WebCore::IDBTransactionInfo const&), WebCore::IDBTransactionInfo const&)::'lambda'()>, void ()>::operator()() + 44 (functional:1407)
8   com.apple.WebCore             	0x0000000112beb9ba std::__1::function<void ()>::operator()() const + 26 (functional:1793)
9   com.apple.WebCore             	0x000000011394a035 WebCore::CrossThreadTask::performTask() + 21 (CrossThreadTask.h:46)
10  com.apple.WebCore             	0x0000000113947e03 WebCore::IDBServer::IDBServer::databaseRunLoop() + 275 (IDBServer.cpp:416)
11  com.apple.WebCore             	0x0000000113945904 WebCore::IDBServer::IDBServer::databaseThreadEntry(void*) + 84 (IDBServer.cpp:406)
12  com.apple.JavaScriptCore      	0x0000000110b4e599 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const + 25 (Threading.cpp:82)
13  com.apple.JavaScriptCore      	0x0000000110b4e56d void std::__1::__invoke_void_return_wrapper<void>::__call<WTF::createThread(void (*)(void*), void*, char const*)::$_0&>(WTF::createThread(void (*)(void*), void*, char const*)::$_0&&&) + 45 (__functional_base:441)
14  com.apple.JavaScriptCore      	0x0000000110b4e50c std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() + 44 (functional:1407)
15  com.apple.JavaScriptCore      	0x0000000110412f3a std::__1::function<void ()>::operator()() const + 26 (functional:1793)
16  com.apple.JavaScriptCore      	0x0000000110b4d26e WTF::threadEntryPoint(void*) + 158 (Threading.cpp:58)
17  com.apple.JavaScriptCore      	0x0000000110b4eb01 WTF::wtfThreadEntryPoint(void*) + 289 (ThreadingPthreads.cpp:164)
18  libsystem_pthread.dylib       	0x00007fff9b91cc13 _pthread_body + 131
19  libsystem_pthread.dylib       	0x00007fff9b91cb90 _pthread_start + 168
20  libsystem_pthread.dylib       	0x00007fff9b91a375 thread_start + 13

[Ryan Haddad]

Since the test is both failing and crashing, I skipped it on mac-wk2 with <http://trac.webkit.org/projects/webkit/changeset/197152>

[Brady Eidson]

<rdar://problem/24874444>

[Brady Eidson]

This is the "DatabaseProcess uses too many file descriptors, therefore the SQLiteDB cannot be opened" bug that is being fixed in https://bugs.webkit.org/show_bug.cgi?id=154922

[Brady Eidson]

That was fixed in <http://trac.webkit.org/changeset/197474>

Unskipping this.

[Brady Eidson]

Created attachment 272706 [details]
Patch for landing

I'll cq+ this patch later once I've confirmed the test is fixed locally.

[WebKit Commit Bot]

Comment on attachment 272706 [details]
Patch for landing

Clearing flags on attachment: 272706

Committed r197510: <http://trac.webkit.org/changeset/197510>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.