Bug 154684 - [Win][CMake] Don't use incremental linking
Summary: [Win][CMake] Don't use incremental linking
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-25 10:51 PST by Brent Fulgham
Modified: 2016-02-25 11:36 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2016-02-25 11:03 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-02-25 10:51:16 PST 
The incremental linking features in MSVC create unacceptably long build and link times. Our hand-crafted project files always had "/INCREMENTAL:NO" set, but CMake didn't know to do that.

This change to the CMake rules causes our generated projects to have "/INCREMENTAL:NO" set properly.
Comment 1 Brent Fulgham 2016-02-25 10:51:29 PST 
<rdar://problem/24747822>
Comment 2 Brent Fulgham 2016-02-25 11:03:38 PST 
Created attachment 272219 [details]
Patch
Comment 3 Brent Fulgham 2016-02-25 11:19:28 PST 
Note: The "/INCREMENTAL:YES" is being set by CMake internally:

https://cmake.org/pipermail/cmake/2010-February/035174.html

See local file "cmake-2.8\Modules\Platform\Windows-cl.cmake" for details of this been set.
Comment 4 WebKit Commit Bot 2016-02-25 11:36:47 PST 
Comment on attachment 272219 [details]
Patch

Clearing flags on attachment: 272219

Committed r197124: <http://trac.webkit.org/changeset/197124>
Comment 5 WebKit Commit Bot 2016-02-25 11:36:50 PST 
All reviewed patches have been landed.  Closing bug.