Bug 154671 – Move streams tests from web-platform-tests/streams-api to web-platform-tests/streams

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

Streams API tests have been uploaded in wpt repo in the "streams" folder.
Let's align with it.

[youenn fablet]

Created attachment 272180 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 272180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272180&action=review

Easy renaming. Please, make suggested changes in the changelog before landing.

> LayoutTests/imported/w3c/ChangeLog:20
> +        (test):
> +        (test.const.highWaterMarkObjectGetter.get highWaterMark):
> +        (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark):
> +        (set string_appeared_here):
> +        (test.const.chunkGetter.get byteLength):
> +        (test.const.chunkGetterThrowing.get byteLength):
> +        (test.const.chunk.get byteLength):

Please, remove functions empty comments from here and the other files as it is non important and offers no relevant information.

[youenn fablet]

Created attachment 272181 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to comment #2)
> Comment on attachment 272180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272180&action=review
> 
> Easy renaming. Please, make suggested changes in the changelog before
> landing.
> 
> > LayoutTests/imported/w3c/ChangeLog:20
> > +        (test):
> > +        (test.const.highWaterMarkObjectGetter.get highWaterMark):
> > +        (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark):
> > +        (set string_appeared_here):
> > +        (test.const.chunkGetter.get byteLength):
> > +        (test.const.chunkGetterThrowing.get byteLength):
> > +        (test.const.chunk.get byteLength):
> 
> Please, remove functions empty comments from here and the other files as it
> is non important and offers no relevant information.

Done in the landing patch.

[WebKit Commit Bot]

Comment on attachment 272181 [details]
Patch for landing

Rejecting attachment 272181 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 272181, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Xabier Rodriguez Calvar found in /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/880911

[youenn fablet]

Created attachment 272182 [details]
Patch for landing

[youenn fablet]

(In reply to comment #5)
> Comment on attachment 272181 [details]
> Patch for landing
> 
> Xabier Rodriguez Calvar found in
> /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear
> to be a valid reviewer according to contributors.json.

Hum, it seems I should have written "Xabier Rodriguez-Calvar" and not "Xabier Rodriguez Calvar". Let's see if it works now!

[WebKit Commit Bot]

Comment on attachment 272182 [details]
Patch for landing

Clearing flags on attachment: 272182

Committed r197090: <http://trac.webkit.org/changeset/197090>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.