Bug 154671 - Move streams tests from web-platform-tests/streams-api to web-platform-tests/streams
Summary: Move streams tests from web-platform-tests/streams-api to web-platform-tests/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-25 00:17 PST by youenn fablet
Modified: 2016-02-25 02:35 PST (History)
4 users (show)

See Also:


Attachments
Patch (393.18 KB, patch)
2016-02-25 00:36 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (389.56 KB, patch)
2016-02-25 01:21 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (389.56 KB, patch)
2016-02-25 01:33 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-02-25 00:17:24 PST
Streams API tests have been uploaded in wpt repo in the "streams" folder.
Let's align with it.
Comment 1 youenn fablet 2016-02-25 00:36:10 PST
Created attachment 272180 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2016-02-25 01:04:49 PST
Comment on attachment 272180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272180&action=review

Easy renaming. Please, make suggested changes in the changelog before landing.

> LayoutTests/imported/w3c/ChangeLog:20
> +        (test):
> +        (test.const.highWaterMarkObjectGetter.get highWaterMark):
> +        (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark):
> +        (set string_appeared_here):
> +        (test.const.chunkGetter.get byteLength):
> +        (test.const.chunkGetterThrowing.get byteLength):
> +        (test.const.chunk.get byteLength):

Please, remove functions empty comments from here and the other files as it is non important and offers no relevant information.
Comment 3 youenn fablet 2016-02-25 01:21:48 PST
Created attachment 272181 [details]
Patch for landing
Comment 4 youenn fablet 2016-02-25 01:22:55 PST
Thanks for the review.

(In reply to comment #2)
> Comment on attachment 272180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272180&action=review
> 
> Easy renaming. Please, make suggested changes in the changelog before
> landing.
> 
> > LayoutTests/imported/w3c/ChangeLog:20
> > +        (test):
> > +        (test.const.highWaterMarkObjectGetter.get highWaterMark):
> > +        (test.const.highWaterMarkObjectGetterThrowing.get highWaterMark):
> > +        (set string_appeared_here):
> > +        (test.const.chunkGetter.get byteLength):
> > +        (test.const.chunkGetterThrowing.get byteLength):
> > +        (test.const.chunk.get byteLength):
> 
> Please, remove functions empty comments from here and the other files as it
> is non important and offers no relevant information.

Done in the landing patch.
Comment 5 WebKit Commit Bot 2016-02-25 01:25:22 PST
Comment on attachment 272181 [details]
Patch for landing

Rejecting attachment 272181 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 272181, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Xabier Rodriguez Calvar found in /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/880911
Comment 6 youenn fablet 2016-02-25 01:33:10 PST
Created attachment 272182 [details]
Patch for landing
Comment 7 youenn fablet 2016-02-25 01:34:09 PST
(In reply to comment #5)
> Comment on attachment 272181 [details]
> Patch for landing
> 
> Xabier Rodriguez Calvar found in
> /Volumes/Data/EWS/WebKit/LayoutTests/imported/w3c/ChangeLog does not appear
> to be a valid reviewer according to contributors.json.

Hum, it seems I should have written "Xabier Rodriguez-Calvar" and not "Xabier Rodriguez Calvar". Let's see if it works now!
Comment 8 WebKit Commit Bot 2016-02-25 02:35:46 PST
Comment on attachment 272182 [details]
Patch for landing

Clearing flags on attachment: 272182

Committed r197090: <http://trac.webkit.org/changeset/197090>
Comment 9 WebKit Commit Bot 2016-02-25 02:35:51 PST
All reviewed patches have been landed.  Closing bug.