Bug 154651 - [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
Summary: [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 154870
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-24 13:13 PST by Konstantin Tokarev
Modified: 2016-03-02 14:45 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2016-02-24 13:18 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (6.00 KB, patch)
2016-03-02 10:24 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-02-24 13:13:58 PST 
Moved PRE/POST_BUILD_COMMAND handling code to WEBKIT_FRAMEWORK macro.
Comment 1 Konstantin Tokarev 2016-02-24 13:18:31 PST 
Created attachment 272143 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-24 15:47:20 PST 
Comment on attachment 272143 [details]
Patch

Clearing flags on attachment: 272143

Committed r197056: <http://trac.webkit.org/changeset/197056>
Comment 3 WebKit Commit Bot 2016-02-24 15:47:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2016-03-01 11:44:30 PST 
Re-opened since this is blocked by bug 154870
Comment 5 Konstantin Tokarev 2016-03-02 10:24:02 PST 
Created attachment 272664 [details]
Patch
Comment 6 Konstantin Tokarev 2016-03-02 13:50:15 PST 
I've fixed copy-paste bug in POST_BUILD COMMAND implementation and used phony target instead of CMake's PRE_BUILD COMMAND feature because the latter actually generates pre-link target instead of pre-build.
Comment 7 Alex Christensen 2016-03-02 13:54:14 PST 
Comment on attachment 272664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272664&action=review

> ChangeLog:10
> +        CMake's PRE_BUILD COMMAND feature because the latter actually
> +        generates pre-link target instead of pre-build.

PRE_BUILD command generates pre-link targets when using ninja but pre-build targets when using Visual Studio.  This is more consistent.
Comment 8 WebKit Commit Bot 2016-03-02 14:45:37 PST 
Comment on attachment 272664 [details]
Patch

Clearing flags on attachment: 272664

Committed r197468: <http://trac.webkit.org/changeset/197468>
Comment 9 WebKit Commit Bot 2016-03-02 14:45:41 PST 
All reviewed patches have been landed.  Closing bug.