Bug 154644 - Web Inspector: TimelineViews should use the recording's end time when entire ruler range is selected
Summary: Web Inspector: TimelineViews should use the recording's end time when entire ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 153033
  Show dependency treegraph
 
Reported: 2016-02-24 10:57 PST by Matt Baker
Modified: 2016-02-24 12:19 PST (History)
8 users (show)

See Also:


Attachments
[Video] capturing w/ select all enabled (2.06 MB, video/mp4)
2016-02-24 10:58 PST, Matt Baker
no flags Details
[Patch] Proposed Fix (4.99 KB, patch)
2016-02-24 11:12 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-02-24 10:57:19 PST
* SUMMARY
TimelineViews should use the recording's end time when entire ruler range is selected. When everything is selected, TimelineRuler.selectionEndTime is equal to Number.MAX_VALUE. Grid-based timeline views can make use this value for filtering/updating rows, but graph-based views (OverviewTimelineView and MemoryTimelineView) require an actual time value to draw graph bars, etc.

When "select all" is enabled, TimelineRecordingContentView should set a massaged end time for child timeline views:

1. While capturing, the recording end time is NaN, so use the current time.
2. When not capturing, the recording end time should be used.
Comment 1 Radar WebKit Bug Importer 2016-02-24 10:57:56 PST
<rdar://problem/24818442>
Comment 2 Matt Baker 2016-02-24 10:58:26 PST
Created attachment 272121 [details]
[Video] capturing w/ select all enabled

OverviewTimelineView live-updates
Comment 3 Matt Baker 2016-02-24 11:12:27 PST
Created attachment 272123 [details]
[Patch] Proposed Fix
Comment 4 WebKit Commit Bot 2016-02-24 12:19:43 PST
Comment on attachment 272123 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 272123

Committed r197039: <http://trac.webkit.org/changeset/197039>
Comment 5 WebKit Commit Bot 2016-02-24 12:19:48 PST
All reviewed patches have been landed.  Closing bug.