Bug 154634 - FontCascadeFonts should downgrade its Ref<FontSelector> to a WeakPtr
Summary: FontCascadeFonts should downgrade its Ref<FontSelector> to a WeakPtr
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 153346
  Show dependency tree / graph
 
Reported: 2016-02-23 22:26 PST by Myles C. Maxfield
Modified: 2016-02-23 22:57 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-02-23 22:26:26 PST 
After the document is destroyed, it doesn't make any sense for a font to extend the lifetime of the font selector.

Once this is done, CSSFontSelector can probably be a std::unique_ptr or even a raw member variable of Document.
Comment 1 Myles C. Maxfield 2016-02-23 22:57:46 PST 
This should be done for all references to a FontSelector, except for the Document's.