In RenderBlock (availableLogicalWidthForLine etc) and through the dependencies.
Created attachment 272082 [details] Patch This patch has a source dependency on bug 154019.
Created attachment 272083 [details] Patch
Comment on attachment 272083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review > Source/WebCore/rendering/RootInlineBox.cpp:724 > + LayoutUnit nextLeft = blockFlow().logicalLeftOffsetForLine(nextTop, DoNotIndentText); > + LayoutUnit nextRight = blockFlow().logicalRightOffsetForLine(nextTop, DoNotIndentText); > + LayoutUnit newLeft = blockFlow().logicalLeftOffsetForLine(selectionBottom, DoNotIndentText); > + LayoutUnit newRight = blockFlow().logicalRightOffsetForLine(selectionBottom, DoNotIndentText); Seems like DoNot is much more common; maybe make it a default parameter?
Comment on attachment 272083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272083&action=review > Source/WebCore/rendering/RenderBlock.h:125 > + LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent? IndentionRequired?
Committed r197462: <http://trac.webkit.org/changeset/197462>
(In reply to comment #4) > Comment on attachment 272083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272083&action=review > > > Source/WebCore/rendering/RenderBlock.h:125 > > + LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const > > I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent? > IndentionRequired? I dislike it very much too, but i'd rather have it in a follow-up patch.