Bug 154620 - Fix downloads when using NetworkSession
Summary: Fix downloads when using NetworkSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-23 17:42 PST by Alex Christensen
Modified: 2016-02-25 08:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (21.94 KB, patch)
2016-02-23 17:42 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (27.44 KB, patch)
2016-02-24 11:26 PST, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-02-23 17:42:17 PST 
Fix downloads when using NetworkSession
Comment 1 Alex Christensen 2016-02-23 17:42:35 PST 
Created attachment 272071 [details]
Patch
Comment 2 Alex Christensen 2016-02-23 17:43:33 PST 
Comment on attachment 272071 [details]
Patch

This first patch fixes all the API tests, but I'm not sure if everything is necessary and there's probably a better way for some of the things.
Comment 3 Alex Christensen 2016-02-24 11:26:44 PST 
Created attachment 272127 [details]
Patch
Comment 4 Brady Eidson 2016-02-24 13:22:11 PST 
Comment on attachment 272127 [details]
Patch

Makes things work, doesn't break other things, it must be right; Right?
Comment 5 Alex Christensen 2016-02-24 13:44:06 PST 
http://trac.webkit.org/changeset/197050
Comment 6 Darin Adler 2016-02-25 08:46:05 PST 
Comment on attachment 272127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272127&action=review

> Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm:281
>      auto downloadID = m_downloadMap.take(taskIdentifier);
> -    ASSERT(downloadID.downloadID());
>      return downloadID;

In a case like this, I would like to see us remove the local variable when refactoring to remove the line of code in between.