RESOLVED FIXED Bug 154615
Web Inspector: teach the Objective-C protocol generators about --frontend and --backend directives 
https://bugs.webkit.org/show_bug.cgi?id=154615
Summary Web Inspector: teach the Objective-C protocol generators about --frontend and...
Blaze Burg
Reported 2016-02-23 16:37:32 PST
patch^soon
Attachments
Proposed Fix (54.07 KB, patch)
2016-02-23 16:48 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (65.84 KB, patch)
2016-02-23 17:10 PST, Blaze Burg 		timothy: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-23 16:38:07 PST
<rdar://problem/24804330>
Blaze Burg
Comment 2 2016-02-23 16:48:16 PST
Created attachment 272064 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-02-23 16:49:12 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Blaze Burg
Comment 4 2016-02-23 17:10:50 PST
Created attachment 272067 [details] Proposed Fix This needs to land at the same time as an internal change, so do not cq+.
Blaze Burg
Comment 5 2016-02-23 17:11:41 PST
(In reply to comment #4) > Created attachment 272067 [details] > Proposed Fix > > This needs to land at the same time as an internal change, so do not cq+. I think there is one other bug that we don't include the Private header from the AutomationProtocolTypes.mm file, but my build might have been stale. Will investigate.
WebKit Commit Bot
Comment 6 2016-02-23 17:13:12 PST
Attachment 272067 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:58: whitespace before ']' [pep8/E202] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 7 2016-02-23 22:43:13 PST
Committed r197013: <http://trac.webkit.org/changeset/197013>
Note You need to log in before you can comment on or make changes to this bug.