Bug 154610 - LayoutTest inspector/dom-debugger/node-removed.html is flaky
Summary: LayoutTest inspector/dom-debugger/node-removed.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-23 14:46 PST by Ryan Haddad
Modified: 2019-10-09 22:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.02 KB, patch)
2019-10-09 18:09 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch for landing (6.78 KB, patch)
2019-10-09 21:36 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch for landing (6.78 KB, patch)
2019-10-09 21:37 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-02-23 14:46:43 PST 
LayoutTest inspector/dom-debugger/node-removed.html is flaky

This test intermittently times out on El Capitan and Yosemite

Most recent timeout:
<https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r196990%20(10256)/results.html>

Flakiness dashboard:
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdom-debugger%2Fnode-removed.html>

--- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/dom-debugger/node-removed-expected.txt
+++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/dom-debugger/node-removed-actual.txt
@@ -1,8 +1,2 @@
-Testing that DOM.childNodeRemoved is correctly triggered even when the element is moved while paused in the debugger on a DOMDebugger "node-removed" breakpoint.
+FAIL: Timed out waiting for notifyDone to be called
 
-Found <script>
-Stopped on DOM breakpoint
-PASS: onChildNodeRemoved called for #target_element
-PASS: onChildNodeInserted called for parent node #final_container
-PASS: onChildNodeInserted called for child node #target_element
-
Comment 1 Radar WebKit Bug Importer 2016-02-23 14:47:04 PST 
<rdar://problem/24801209>
Comment 2 Ryan Haddad 2017-02-15 09:59:07 PST 
Marked test as flaky in https://trac.webkit.org/r212369
Comment 3 Yury Semikhatsky 2019-10-09 18:09:54 PDT 
Created attachment 380598 [details]
Patch
Comment 4 Matt Baker 2019-10-09 19:25:46 PDT 
Comment on attachment 380598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380598&action=review

r=me, please remove debug settings before landing.

> LayoutTests/inspector/dom-debugger/node-removed.html:19
> +    ProtocolTest.dumpInspectorProtocolMessages = true;

Debug settings should be removed.
Comment 5 Yury Semikhatsky 2019-10-09 21:36:19 PDT 
Created attachment 380604 [details]
Patch for landing
Comment 6 Yury Semikhatsky 2019-10-09 21:37:01 PDT 
Comment on attachment 380598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380598&action=review

>> LayoutTests/inspector/dom-debugger/node-removed.html:19
>> +    ProtocolTest.dumpInspectorProtocolMessages = true;
> 
> Debug settings should be removed.

Oops. Removed.
Comment 7 Yury Semikhatsky 2019-10-09 21:37:41 PDT 
Created attachment 380605 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-10-09 22:28:25 PDT 
Comment on attachment 380605 [details]
Patch for landing

Clearing flags on attachment: 380605

Committed r250956: <https://trac.webkit.org/changeset/250956>
Comment 9 WebKit Commit Bot 2019-10-09 22:28:27 PDT 
All reviewed patches have been landed.  Closing bug.