Bug 154610 – LayoutTest inspector/dom-debugger/node-removed.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Ryan Haddad]

LayoutTest inspector/dom-debugger/node-removed.html is flaky

This test intermittently times out on El Capitan and Yosemite

Most recent timeout:
<https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r196990%20(10256)/results.html>

Flakiness dashboard:
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdom-debugger%2Fnode-removed.html>

--- /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/dom-debugger/node-removed-expected.txt
+++ /Volumes/Data/slave/yosemite-debug-tests-wk2/build/layout-test-results/inspector/dom-debugger/node-removed-actual.txt
@@ -1,8 +1,2 @@
-Testing that DOM.childNodeRemoved is correctly triggered even when the element is moved while paused in the debugger on a DOMDebugger "node-removed" breakpoint.
+FAIL: Timed out waiting for notifyDone to be called
 
-Found <script>
-Stopped on DOM breakpoint
-PASS: onChildNodeRemoved called for #target_element
-PASS: onChildNodeInserted called for parent node #final_container
-PASS: onChildNodeInserted called for child node #target_element
-

[Radar WebKit Bug Importer]

<rdar://problem/24801209>

[Ryan Haddad]

Marked test as flaky in https://trac.webkit.org/r212369

[Yury Semikhatsky]

Created attachment 380598 [details]
Patch

[Matt Baker]

Comment on attachment 380598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380598&action=review

r=me, please remove debug settings before landing.

> LayoutTests/inspector/dom-debugger/node-removed.html:19
> +    ProtocolTest.dumpInspectorProtocolMessages = true;

Debug settings should be removed.

[Yury Semikhatsky]

Created attachment 380604 [details]
Patch for landing

[Yury Semikhatsky]

Comment on attachment 380598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380598&action=review

>> LayoutTests/inspector/dom-debugger/node-removed.html:19
>> +    ProtocolTest.dumpInspectorProtocolMessages = true;
> 
> Debug settings should be removed.

Oops. Removed.

[Yury Semikhatsky]

Created attachment 380605 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 380605 [details]
Patch for landing

Clearing flags on attachment: 380605

Committed r250956: <https://trac.webkit.org/changeset/250956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.