Bug 154597 - WKPreferences should conform to NSCoding
Summary: WKPreferences should conform to NSCoding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-23 11:29 PST by Anders Carlsson
Modified: 2016-02-23 12:04 PST (History)
0 users

See Also:


Attachments
Patch (2.87 KB, patch)
2016-02-23 11:30 PST, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-02-23 11:29:08 PST
WKPreferences should conform to NSCoding
Comment 1 Anders Carlsson 2016-02-23 11:30:48 PST
Created attachment 272038 [details]
Patch
Comment 2 Sam Weinig 2016-02-23 11:54:50 PST
Comment on attachment 272038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272038&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:70
> +
> +    self.minimumFontSize = [coder decodeDoubleForKey:@"minimumFontSize"];

Might be worth adding a comment about how only properties exposed as API get encoded/decoded.
Comment 3 Anders Carlsson 2016-02-23 12:04:32 PST
Committed r196987: <http://trac.webkit.org/changeset/196987>