Bug 154596 - Web Inspector: the protocol generator's Objective-C name prefix should be configurable
Summary: Web Inspector: the protocol generator's Objective-C name prefix should be con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-23 10:59 PST by BJ Burg
Modified: 2016-02-23 13:49 PST (History)
12 users (show)

See Also:

Attachments
Proposed Fix (271.05 KB, patch)
2016-02-23 12:42 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-02-23 10:59:34 PST 
:|
Comment 1 Radar WebKit Bug Importer 2016-02-23 11:00:01 PST 
<rdar://problem/24794962>
Comment 2 BJ Burg 2016-02-23 12:42:46 PST 
Created attachment 272043 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-02-23 12:44:26 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-02-23 12:44:34 PST 
Attachment 272043 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:44:  [ObjCBackendDispatcherImplementationGenerator.output_filename] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:48:  [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:49:  [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:57:  [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:74:  [ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:106:  [ObjCBackendDispatcherImplementationGenerator._generate_ivars] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:110:  [ObjCBackendDispatcherImplementationGenerator._generate_ivars] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:130:  [ObjCBackendDispatcherImplementationGenerator._generate_handler_setter_for_domain] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:138:  [ObjCBackendDispatcherImplementationGenerator._generate_event_dispatcher_getter_for_domain] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:47:  [ObjCBackendDispatcherHeaderGenerator.output_filename] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:76:  [ObjCBackendDispatcherHeaderGenerator._generate_objc_forward_declarations] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:90:  [ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declarations_for_domain] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:45:  [ObjCFrontendDispatcherImplementationGenerator.output_filename] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:52:  [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:57:  [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:74:  [ObjCFrontendDispatcherImplementationGenerator._generate_event_dispatcher_implementations] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:107:  [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_class_for_array_type' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:108:  [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:115:  [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_class_for_array_type' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:116:  [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:136:  [ObjCFrontendDispatcherImplementationGenerator._generate_event_signature] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_type_for_param' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:147:  [ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_protocol_export_expression_for_variable' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:44:  [ObjCConfigurationHeaderGenerator.output_filename] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:48:  [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:69:  [ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:77:  [ObjCConfigurationHeaderGenerator._generate_properties_for_domain] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:51:  [ObjCConversionHelpersGenerator.output_filename] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:58:  [ObjCConversionHelpersGenerator.generate_output] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:109:  [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_declaration] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_declaration' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:117:  [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_member] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_member' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:125:  [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_parameter] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_parameter' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:85:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:96:  [ObjCGenerator.objc_prefix] Instance of 'ObjCGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 33 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2016-02-23 12:47:17 PST 
(In reply to comment #4)
> Attachment 272043 [details] did not pass style-queue:

check-webkit-style doesn't understand subclassing, as it painfully reminds us every time.
Comment 6 WebKit Commit Bot 2016-02-23 13:49:40 PST 
Comment on attachment 272043 [details]
Proposed Fix

Clearing flags on attachment: 272043

Committed r196993: <http://trac.webkit.org/changeset/196993>
Comment 7 WebKit Commit Bot 2016-02-23 13:49:43 PST 
All reviewed patches have been landed.  Closing bug.