RESOLVED FIXED 154596
Web Inspector: the protocol generator's Objective-C name prefix should be configurable 
https://bugs.webkit.org/show_bug.cgi?id=154596
Summary Web Inspector: the protocol generator's Objective-C name prefix should be con...
Blaze Burg
Reported 2016-02-23 10:59:34 PST
:|
Attachments
Proposed Fix (271.05 KB, patch)
2016-02-23 12:42 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-23 11:00:01 PST
<rdar://problem/24794962>
Blaze Burg
Comment 2 2016-02-23 12:42:46 PST
Created attachment 272043 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-02-23 12:44:26 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2016-02-23 12:44:34 PST
Attachment 272043 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:44: [ObjCBackendDispatcherImplementationGenerator.output_filename] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:48: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:49: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:57: [ObjCBackendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:74: [ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:106: [ObjCBackendDispatcherImplementationGenerator._generate_ivars] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:110: [ObjCBackendDispatcherImplementationGenerator._generate_ivars] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:130: [ObjCBackendDispatcherImplementationGenerator._generate_handler_setter_for_domain] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_implementation.py:138: [ObjCBackendDispatcherImplementationGenerator._generate_event_dispatcher_getter_for_domain] Instance of 'ObjCBackendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:47: [ObjCBackendDispatcherHeaderGenerator.output_filename] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:76: [ObjCBackendDispatcherHeaderGenerator._generate_objc_forward_declarations] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:90: [ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declarations_for_domain] Instance of 'ObjCBackendDispatcherHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:45: [ObjCFrontendDispatcherImplementationGenerator.output_filename] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:52: [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:57: [ObjCFrontendDispatcherImplementationGenerator.generate_output] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:74: [ObjCFrontendDispatcherImplementationGenerator._generate_event_dispatcher_implementations] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:107: [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_class_for_array_type' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:108: [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:115: [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_class_for_array_type' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:116: [ObjCFrontendDispatcherImplementationGenerator._generate_event] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:136: [ObjCFrontendDispatcherImplementationGenerator._generate_event_signature] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_type_for_param' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:147: [ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters] Instance of 'ObjCFrontendDispatcherImplementationGenerator' has no 'objc_protocol_export_expression_for_variable' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:44: [ObjCConfigurationHeaderGenerator.output_filename] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:48: [ObjCConfigurationHeaderGenerator.generate_output] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:69: [ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_configuration_header.py:77: [ObjCConfigurationHeaderGenerator._generate_properties_for_domain] Instance of 'ObjCConfigurationHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:51: [ObjCConversionHelpersGenerator.output_filename] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:58: [ObjCConversionHelpersGenerator.generate_output] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:109: [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_declaration] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_declaration' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:117: [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_member] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_member' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:125: [ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_parameter] Instance of 'ObjCConversionHelpersGenerator' has no 'objc_enum_name_for_anonymous_enum_parameter' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:85: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:96: [ObjCGenerator.objc_prefix] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 33 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 5 2016-02-23 12:47:17 PST
(In reply to comment #4) > Attachment 272043 [details] did not pass style-queue: check-webkit-style doesn't understand subclassing, as it painfully reminds us every time.
WebKit Commit Bot
Comment 6 2016-02-23 13:49:40 PST
Comment on attachment 272043 [details] Proposed Fix Clearing flags on attachment: 272043 Committed r196993: <http://trac.webkit.org/changeset/196993>
WebKit Commit Bot
Comment 7 2016-02-23 13:49:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.