Bug 154590 - [css-grid][css-flex] Make OrderIterator a STL iterator class
Summary: [css-grid][css-flex] Make OrderIterator a STL iterator class
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2016-02-23 09:29 PST by Manuel Rego Casasnovas
Modified: 2016-02-23 09:29 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-02-23 09:29:26 PST 
OrderIterator is used by Grid Layout and Flexbox.

From a comment in bug #154336 it would be nice to make it a STL iterator class:
> > Source/WebCore/rendering/RenderGrid.cpp:1184
> > +    for (RenderBox* child = m_orderIterator.first(); child; child = m_orderIterator.next()) {
> 
> Perhaps not for this patch but we should make OrderIterator a stl
> iterator-like class so that instead of first() and next() we have begin()
> and end() and we could do things like
> 
> for (auto child : m_orderIterator)