Bug 154580 - [WinCairo][MediaFoundation] Implement methods to set volume.
Summary: [WinCairo][MediaFoundation] Implement methods to set volume.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-23 02:36 PST by peavo
Modified: 2016-02-24 11:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2016-02-23 02:41 PST, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2016-02-23 02:36:09 PST 
The methods to adjust the playback volume has not been implemented yet.
Comment 1 peavo 2016-02-23 02:41:13 PST 
Created attachment 272006 [details]
Patch
Comment 2 Alex Christensen 2016-02-23 22:43:26 PST 
Comment on attachment 272006 [details]
Patch

Looks good.  I meant to r+ this earlier, but it crashed as I pushed publish.
By the way, I noticed a graphics issue with the MediaFoundation video player where sometimes parts of the video will be a frame ahead of the other parts.  It looked like the top left 512px x 512px or so was ahead of the rest.  Have you seen that?
Comment 3 WebKit Commit Bot 2016-02-23 23:05:53 PST 
Comment on attachment 272006 [details]
Patch

Clearing flags on attachment: 272006

Committed r197015: <http://trac.webkit.org/changeset/197015>
Comment 4 WebKit Commit Bot 2016-02-23 23:05:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 peavo 2016-02-24 04:08:03 PST 
(In reply to comment #2)
> Comment on attachment 272006 [details]
> Patch
> 
> Looks good.  I meant to r+ this earlier, but it crashed as I pushed publish.
> By the way, I noticed a graphics issue with the MediaFoundation video player
> where sometimes parts of the video will be a frame ahead of the other parts.
> It looked like the top left 512px x 512px or so was ahead of the rest.  Have
> you seen that?

No, I haven't seen that. Is it something new? Is it reproducible on a specific page?

Thanks for reviewing :)
Comment 6 Alex Christensen 2016-02-24 11:49:44 PST 
(In reply to comment #5)
> No, I haven't seen that. Is it something new? Is it reproducible on a
> specific page?
I saw it on vimeo.com