Bug 154577 – Remove IteratorKey and IteratorValue declarations from JSXX class declarations.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[youenn fablet]

Based on bug 154531, we no longer need these type declarations.

[youenn fablet]

Created attachment 271998 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 271998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271998&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:-1062
> -    if ($interface->iterable) {
> -        push(@headerContent, "\n");
> -        if ($interface->iterable->keyType) {
> -            my $keyType = GetNativeType($interface->iterable->keyType);
> -            push(@headerContent, "    using IteratorKey = $keyType;\n");
> -        }
> -        my $valueType = GetNativeType($interface->iterable->valueType);
> -        push(@headerContent, "    using IteratorValue = $valueType;\n");
> -    }
> -

Please delete the line from GetNativeType() that special-cases FontFace too.

[youenn fablet]

Created attachment 272112 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

> Please delete the line from GetNativeType() that special-cases FontFace too.

Done in the landing patch.

[WebKit Commit Bot]

Comment on attachment 272112 [details]
Patch for landing

Clearing flags on attachment: 272112

Committed r197028: <http://trac.webkit.org/changeset/197028>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.