Bug 154570 – Calling importNode on shadow root causes a crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

Calling cloneNode on shadow root causes a crash

[Ryosuke Niwa]

Created attachment 271974 [details]
Fixes the bug

[Ryosuke Niwa]

Created attachment 271975 [details]
Uploaded the change log entries

[Ryosuke Niwa]

https://bugs.webkit.org/show_bug.cgi?id=154570

[Build Bot]

Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/869938

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 271978 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/869954

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 271981 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/869939

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 271982 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Ryosuke Niwa]

Created attachment 271985 [details]
Fixed the tests

[Ryosuke Niwa]

Committed r196998: <http://trac.webkit.org/changeset/196998>

[Darin Adler]

Comment on attachment 271985 [details]
Fixed the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=271985&action=review

> Source/WebCore/dom/Node.h:205
>      Ref<Node> cloneNode(bool deep) { return cloneNodeInternal(document(), deep ? CloningOperation::Everything : CloningOperation::OnlySelf); }

Not so great to have this cloneNode that takes a boolean. For use inside WebKit as opposed to in the bindings should get rid of this and replace by calls have the "deep vs. not" in the names of the functions rather than using a boolean flag.