Bug 154570 - Calling importNode on shadow root causes a crash
Summary: Calling importNode on shadow root causes a crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-22 17:43 PST by Ryosuke Niwa
Modified: 2016-02-23 21:56 PST (History)
10 users (show)

See Also:

Attachments
Fixes the bug (11.37 KB, patch)
2016-02-22 17:43 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Uploaded the change log entries (12.26 KB, patch)
2016-02-22 17:48 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (983.23 KB, application/zip)
2016-02-22 18:41 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (973.10 KB, application/zip)
2016-02-22 18:47 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.29 MB, application/zip)
2016-02-22 18:52 PST, Build Bot 		no flags Details
Fixed the tests (12.09 KB, patch)
2016-02-22 19:32 PST, Ryosuke Niwa 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-02-22 17:43:21 PST 
Calling cloneNode on shadow root causes a crash
Comment 1 Ryosuke Niwa 2016-02-22 17:43:44 PST 
Created attachment 271974 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2016-02-22 17:48:26 PST 
Created attachment 271975 [details]
Uploaded the change log entries
Comment 3 Ryosuke Niwa 2016-02-22 17:49:04 PST 
https://bugs.webkit.org/show_bug.cgi?id=154570
Comment 4 Build Bot 2016-02-22 18:41:29 PST 
Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/869938

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-02-22 18:41:34 PST 
Created attachment 271978 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-02-22 18:46:59 PST 
Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/869954

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-02-22 18:47:04 PST 
Created attachment 271981 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-02-22 18:52:23 PST 
Comment on attachment 271975 [details]
Uploaded the change log entries

Attachment 271975 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/869939

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-02-22 18:52:28 PST 
Created attachment 271982 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Ryosuke Niwa 2016-02-22 19:32:36 PST 
Created attachment 271985 [details]
Fixed the tests
Comment 11 Ryosuke Niwa 2016-02-23 14:35:37 PST 
Committed r196998: <http://trac.webkit.org/changeset/196998>
Comment 12 Darin Adler 2016-02-23 21:56:47 PST 
Comment on attachment 271985 [details]
Fixed the tests

View in context: https://bugs.webkit.org/attachment.cgi?id=271985&action=review

> Source/WebCore/dom/Node.h:205
>      Ref<Node> cloneNode(bool deep) { return cloneNodeInternal(document(), deep ? CloningOperation::Everything : CloningOperation::OnlySelf); }

Not so great to have this cloneNode that takes a boolean. For use inside WebKit as opposed to in the bindings should get rid of this and replace by calls have the "deep vs. not" in the names of the functions rather than using a boolean flag.