Native Typed Array functions should use Symbol.species
Created attachment 272144 [details] Patch
Attachment 272144 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 272144 [details] Patch Attachment 272144 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/878903 New failing tests: fast/canvas/webgl/array-set-invalid-arguments.html js/typedarray-set-overlapping-elements-of-same-size.html fast/canvas/webgl/webgl-array-invalid-ranges.html js/typedarray-set-same-type-memmove.html fast/canvas/webgl/array-unit-tests.html webgl/1.0.2/conformance/typedarrays/array-unit-tests.html webgl/1.0.2/conformance/textures/texture-size-cube-maps.html fast/canvas/webgl/array-setters.html webgl/1.0.2/conformance/textures/texture-size.html
Created attachment 272149 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 272144 [details] Patch Attachment 272144 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/878946 New failing tests: fast/canvas/webgl/array-set-invalid-arguments.html fast/canvas/webgl/webgl-array-invalid-ranges.html js/typedarray-set-overlapping-elements-of-same-size.html js/typedarray-set-same-type-memmove.html fast/canvas/webgl/array-unit-tests.html webgl/1.0.2/conformance/typedarrays/array-unit-tests.html webgl/1.0.2/conformance/textures/texture-size-cube-maps.html fast/canvas/webgl/array-setters.html webgl/1.0.2/conformance/textures/texture-size.html
Created attachment 272152 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 272144 [details] Patch Attachment 272144 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/878938 New failing tests: fast/canvas/webgl/array-set-invalid-arguments.html js/typedarray-set-overlapping-elements-of-same-size.html fast/canvas/webgl/webgl-array-invalid-ranges.html js/typedarray-set-same-type-memmove.html fast/canvas/webgl/array-unit-tests.html webgl/1.0.2/conformance/typedarrays/array-unit-tests.html webgl/1.0.2/conformance/textures/texture-size-cube-maps.html fast/canvas/webgl/array-setters.html webgl/1.0.2/conformance/textures/texture-size.html
Created attachment 272153 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 272156 [details] Patch
Attachment 272156 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272157 [details] Patch
Attachment 272157 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272159 [details] Patch
Attachment 272159 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272221 [details] Patch
Attachment 272221 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272229 [details] Patch
Attachment 272229 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272248 [details] Patch
Attachment 272248 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:228: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 272248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272248&action=review r=me with comments. > Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:201 > + // This method doesn't currently support an otherOffset when type != CopyType::LeftToRight. > + // In theory there is no reason why this method couldn't, in fact, it probably already works, > + // it's just not tested. > + ASSERT(!otherOffset || type != CopyType::LeftToRight); Since we don't think !otherOffset is likely and we haven't tested it, let's either test it and remove the comment, make sure we properly handle it here, or handle it as case (3). > Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:279 > + // This method doesn't currently support an objectOffset when object is not a TypedArray view. > + // In theory there is no reason why this method couldn't, in fact it probably already works, > + // it's just not tested. > + ASSERT(!objectOffset); Let's remove this comment and ASSERT, as the object->get() below will make sure things work correctly.
Created attachment 272350 [details] Patch for landing
Comment on attachment 272350 [details] Patch for landing Clearing flags on attachment: 272350 Committed r197192: <http://trac.webkit.org/changeset/197192>
All reviewed patches have been landed. Closing bug.