Bug 154568 - Add tests for fast click change in r196679
Summary: Add tests for fast click change in r196679
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-22 17:22 PST by Dean Jackson
Modified: 2016-02-23 12:40 PST (History)
1 user (show)

See Also:


Attachments
Patch (20.59 KB, patch)
2016-02-22 17:27 PST, Dean Jackson
mmaxfield: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-02-22 17:22:17 PST
Add tests for fast click change in r196679
Comment 1 Radar WebKit Bug Importer 2016-02-22 17:23:07 PST
<rdar://problem/24782479>
Comment 2 Dean Jackson 2016-02-22 17:27:14 PST
Created attachment 271972 [details]
Patch
Comment 3 Myles C. Maxfield 2016-02-22 17:35:53 PST
Comment on attachment 271972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271972&action=review

> LayoutTests/platform/ios-simulator/TestExpectations:2845
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-sends-click.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-text.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-image.html  [ Pass Timeout ]
> +webkit.org/b/152134 fast/events/ios/no-fast-click-double-tap-causes-zoom.html  [ Pass Timeout ]

Can we do something to make sure these never timeout?
Comment 4 Dean Jackson 2016-02-23 10:52:05 PST
(In reply to comment #3)

> > LayoutTests/platform/ios-simulator/TestExpectations:2845
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-sends-click.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-text.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/fast-click-double-tap-zooms-on-image.html  [ Pass Timeout ]
> > +webkit.org/b/152134 fast/events/ios/no-fast-click-double-tap-causes-zoom.html  [ Pass Timeout ]
> 
> Can we do something to make sure these never timeout?

Fix webkit.org/b/152134 ?

I've filed a radar and assigned it to Simon. I'm not sure if it is the UI scripting stuff that's causing the issue.

Maybe we should turn that off and see if it still happens.
Comment 5 Dean Jackson 2016-02-23 12:40:00 PST
Committed r196989: <http://trac.webkit.org/changeset/196989>