RESOLVED FIXED 154562
Refactor script that updates fullscreen buttons. 
https://bugs.webkit.org/show_bug.cgi?id=154562
Summary Refactor script that updates fullscreen buttons.
Ada Chan
Reported 2016-02-22 15:44:36 PST
Centralize all logic to add/update picture-in-picture button in updatePictureInPictureButton().
Attachments
Patch (3.32 KB, patch)
2016-02-22 17:21 PST, Ada Chan 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2016-02-23 14:57 PST, Ada Chan 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-02-22 15:45:43 PST
<rdar://problem/24550383>
Ada Chan
Comment 2 2016-02-22 17:21:31 PST
Created attachment 271969 [details] Patch
Ada Chan
Comment 3 2016-02-23 14:52:03 PST
Found a small issue that I need to fix. Posting a new patch shortly.
Ada Chan
Comment 4 2016-02-23 14:57:45 PST
Created attachment 272054 [details] Patch
Ada Chan
Comment 5 2016-02-23 16:31:16 PST
Committed: http://trac.webkit.org/changeset/197005
Note You need to log in before you can comment on or make changes to this bug.