Bug 154562 - Refactor script that updates fullscreen buttons.
Summary: Refactor script that updates fullscreen buttons.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-22 15:44 PST by Ada Chan
Modified: 2016-02-23 16:31 PST (History)
0 users

See Also:

Attachments
Patch (3.32 KB, patch)
2016-02-22 17:21 PST, Ada Chan 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2016-02-23 14:57 PST, Ada Chan 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-02-22 15:44:36 PST 
Centralize all logic to add/update picture-in-picture button in updatePictureInPictureButton().
Comment 1 Ada Chan 2016-02-22 15:45:43 PST 
<rdar://problem/24550383>
Comment 2 Ada Chan 2016-02-22 17:21:31 PST 
Created attachment 271969 [details]
Patch
Comment 3 Ada Chan 2016-02-23 14:52:03 PST 
Found a small issue that I need to fix.  Posting a new patch shortly.
Comment 4 Ada Chan 2016-02-23 14:57:45 PST 
Created attachment 272054 [details]
Patch
Comment 5 Ada Chan 2016-02-23 16:31:16 PST 
Committed:
http://trac.webkit.org/changeset/197005