Bug 154556 - [cmake] Set precompiled headers via ${_target}_PRECOMPILED_HEADER variables.
Summary: [cmake] Set precompiled headers via ${_target}_PRECOMPILED_HEADER variables.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-22 13:55 PST by Konstantin Tokarev
Modified: 2016-02-23 22:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.80 KB, patch)
2016-02-22 14:00 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (4.80 KB, patch)
2016-02-23 02:15 PST, Konstantin Tokarev 		achristensen: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-02-22 13:55:44 PST 
This patch allows customization of precompiled headers in Platform files.
Comment 1 Konstantin Tokarev 2016-02-22 14:00:24 PST 
Created attachment 271954 [details]
Patch
Comment 2 Konstantin Tokarev 2016-02-23 02:15:12 PST 
Created attachment 272002 [details]
Patch
Comment 3 Alex Christensen 2016-02-23 09:18:59 PST 
Comment on attachment 272002 [details]
Patch

I don't think this reduces complexity at all.  Why is this a useful change?
Comment 4 Konstantin Tokarev 2016-02-23 09:43:25 PST 
It allows setting different precompiled headers for different ports.. OK, I probably shoudn't have submitted this change until PCH support for gcc/clang is ready.
Comment 5 Alex Christensen 2016-02-23 22:49:12 PST 
Comment on attachment 272002 [details]
Patch

I agree.  As-is, this patch adds nothing, but it makes it a little harder to see what is going on with the precompiled headers.