Bug 154526 - Web Inspector: Dim selected items when docked Inspector window is inactive
Summary: Web Inspector: Dim selected items when docked Inspector window is inactive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-21 22:23 PST by Nikita Vasilyev
Modified: 2016-02-24 09:06 PST (History)
8 users (show)

See Also:

Attachments
[Animated GIF] Active/inactive (270.51 KB, image/gif)
2016-02-21 22:23 PST, Nikita Vasilyev 		no flags Details
WIP (12.75 KB, patch)
2016-02-21 22:29 PST, Nikita Vasilyev 		timothy: review+
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
[Animated GIF] Xcode active/inactive window (28.63 KB, image/gif)
2016-02-23 15:02 PST, Nikita Vasilyev 		no flags Details
Patch (13.80 KB, patch)
2016-02-23 22:38 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] Active/inactive (269.03 KB, image/gif)
2016-02-23 22:44 PST, Nikita Vasilyev 		no flags Details
[Image] Clipped icons (5.17 KB, image/png)
2016-02-23 22:51 PST, Nikita Vasilyev 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-02-21 22:23:18 PST 
Created attachment 271903 [details]
[Animated GIF] Active/inactive

This would match OS X behavior.
Comment 1 Radar WebKit Bug Importer 2016-02-21 22:23:40 PST 
<rdar://problem/24764365>
Comment 2 Nikita Vasilyev 2016-02-21 22:29:25 PST 
Created attachment 271905 [details]
WIP

What do you think?
Comment 3 Timothy Hatcher 2016-02-22 08:43:42 PST 
Looks good. We should do this.
Comment 4 Timothy Hatcher 2016-02-23 13:49:32 PST 
Comment on attachment 271905 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=271905&action=review

> Source/WebInspectorUI/UserInterface/Views/Variables.css:35
> +    --selected-color: white;

Maybe --selected-foreground-color?
Comment 5 Nikita Vasilyev 2016-02-23 15:02:57 PST 
Created attachment 272057 [details]
[Animated GIF] Xcode active/inactive window

When Xcode window isn't in focus, the color of selected items and glyphs
is dim blue, not grey. Should we do the same?
Comment 6 Timothy Hatcher 2016-02-23 15:08:31 PST 
Yeah, for the buttons I think it makes sense to use a dim blue like Xcode.

I noticed after looking again at your Inspector GIF that the toolbar toggle button in the navigation bar is looks disabled when the window is inactive. That does not look right. Maybe the blue will help.
Comment 7 Nikita Vasilyev 2016-02-23 22:38:31 PST 
Created attachment 272094 [details]
Patch
Comment 8 Nikita Vasilyev 2016-02-23 22:44:55 PST 
Created attachment 272095 [details]
[Animated GIF] Active/inactive
Comment 9 Nikita Vasilyev 2016-02-23 22:51:00 PST 
Created attachment 272097 [details]
[Image] Clipped icons

Accidentally, this patch also fixes the bug with clipped icons
by switching away from using opacity on SVG elements, which
appears to be a WebKit bug.
Comment 10 Nikita Vasilyev 2016-02-23 22:52:37 PST 
(In reply to comment #9)
> Created attachment 272097 [details]
> [Image] Clipped icons
> 
> Accidentally, this patch also fixes the bug with clipped icons
> by switching away from using opacity on SVG elements, which
> appears to be a WebKit bug.

To clarify, this image shows how it looked before the patch.
Comment 11 Timothy Hatcher 2016-02-24 08:17:56 PST 
Comment on attachment 272094 [details]
Patch

Great!
Comment 12 WebKit Commit Bot 2016-02-24 09:06:45 PST 
Comment on attachment 272094 [details]
Patch

Clearing flags on attachment: 272094

Committed r197029: <http://trac.webkit.org/changeset/197029>
Comment 13 WebKit Commit Bot 2016-02-24 09:06:49 PST 
All reviewed patches have been landed.  Closing bug.