Bug 154524 – [iOS Simulator] js/number-toLocaleString.html failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

[iOS Simulator] js/number-toLocaleString.html failing

This test has been failing since r196850

<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r196881%20(3304)/results.html>
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fnumber-toLocaleString.html>

--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-actual.txt
@@ -20,7 +20,7 @@
 PASS (0).toLocaleString() is "0"
 PASS new Number(1).toLocaleString() is "1"
 PASS (0).toLocaleString('i') threw exception RangeError: invalid language tag: i.
-PASS Infinity.toLocaleString() is "∞"
+FAIL Infinity.toLocaleString() should be ∞. Was INF.
 PASS (123456.789).toLocaleString('ar') is "١٢٣٬٤٥٦٫٧٨٩"
 PASS (123456.789).toLocaleString('zh-Hans-CN-u-nu-hanidec') is "一二三,四五六.七八九"
 PASS (123.456).toLocaleString('en', { maximumSignificantDigits: 3 }) is "123"

[Ryan Haddad]

Landed an ios-simulator baseline for this test in <http://trac.webkit.org/projects/webkit/changeset/196884> to get the bots back to green.

[Sukolsak Sakshuwong]

I believe this is the same issue as Bug 152448. It is because Intl.NumberFormat uses POSIX locale. The current proposed patch should fix it.

[Sukolsak Sakshuwong]

One way to reproduce this case:

$ LANG=en_US.UTF-8 ./jsc -e "print(Infinity.toLocaleString())"
∞
$ LANG=en_US_POSIX.UTF-8 ./jsc -e "print(Infinity.toLocaleString())"
INF

[Sukolsak Sakshuwong]

This issue has been fixed by https://trac.webkit.org/changeset/197261 Infinity.toLocaleString() now returns "∞" as it should.

https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/r197261%20%283481%29/results.html

[Sukolsak Sakshuwong]

Created attachment 272429 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 272429 [details]
Patch

Clearing flags on attachment: 272429

Committed r197264: <http://trac.webkit.org/changeset/197264>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.