Bug 154524 - [iOS Simulator] js/number-toLocaleString.html failing
Summary: [iOS Simulator] js/number-toLocaleString.html failing
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-02-21 17:26 PST by Ryan Haddad
Modified: 2016-02-27 19:33 PST (History)
3 users (show)

See Also:

Patch (3.36 KB, patch)
2016-02-27 17:45 PST, Sukolsak Sakshuwong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-02-21 17:26:35 PST
[iOS Simulator] js/number-toLocaleString.html failing

This test has been failing since r196850


--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/js/number-toLocaleString-actual.txt
@@ -20,7 +20,7 @@
 PASS (0).toLocaleString() is "0"
 PASS new Number(1).toLocaleString() is "1"
 PASS (0).toLocaleString('i') threw exception RangeError: invalid language tag: i.
-PASS Infinity.toLocaleString() is "∞"
+FAIL Infinity.toLocaleString() should be ∞. Was INF.
 PASS (123456.789).toLocaleString('ar') is "١٢٣٬٤٥٦٫٧٨٩"
 PASS (123456.789).toLocaleString('zh-Hans-CN-u-nu-hanidec') is "一二三,四五六.七八九"
 PASS (123.456).toLocaleString('en', { maximumSignificantDigits: 3 }) is "123"
Comment 1 Ryan Haddad 2016-02-21 17:31:07 PST
Landed an ios-simulator baseline for this test in <http://trac.webkit.org/projects/webkit/changeset/196884> to get the bots back to green.
Comment 2 Sukolsak Sakshuwong 2016-02-21 20:50:22 PST
I believe this is the same issue as Bug 152448. It is because Intl.NumberFormat uses POSIX locale. The current proposed patch should fix it.
Comment 3 Sukolsak Sakshuwong 2016-02-22 08:58:08 PST
One way to reproduce this case:

$ LANG=en_US.UTF-8 ./jsc -e "print(Infinity.toLocaleString())"
$ LANG=en_US_POSIX.UTF-8 ./jsc -e "print(Infinity.toLocaleString())"
Comment 4 Sukolsak Sakshuwong 2016-02-27 17:40:37 PST
This issue has been fixed by https://trac.webkit.org/changeset/197261 Infinity.toLocaleString() now returns "∞" as it should.

Comment 5 Sukolsak Sakshuwong 2016-02-27 17:45:32 PST
Created attachment 272429 [details]
Comment 6 WebKit Commit Bot 2016-02-27 19:33:13 PST
Comment on attachment 272429 [details]

Clearing flags on attachment: 272429

Committed r197264: <http://trac.webkit.org/changeset/197264>
Comment 7 WebKit Commit Bot 2016-02-27 19:33:18 PST
All reviewed patches have been landed.  Closing bug.