Bug 154516 – [JSC shell] Don't put empty arguments array to VM.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Konstantin Tokarev]

This allows arrowfunction-lexical-bind-arguments-top-level test to pass in jsc as well as in browser.

[Konstantin Tokarev]

Created attachment 271884 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 271884 [details]
Patch

I don't think the current approach is good because we would like to assume that there is an empty `arguments` if the CLI does not pass any arguments.

How about the following idea?
1. adding an Option (see runtime/Options.h), that controls exposing the `arguments`. Now, we can control this behavior with the environment variable JSC_XXX (If you add an option XXX, we can switch it with the environment variable JSC_XXX)
3. adding a ruby function notExposeArguments() in run-jsc-stress-tests, which defines JSC_XXX environment variable before executing the command. (Let's define addEnvVar(X, Y). And calling it as def notExposeArguments addEnvVar("JSC_XXX", "true"))
4. defining the annotation "//@ notExposeArguments" instead of "//@ skip"

[Konstantin Tokarev]

(In reply to comment #2)
> Comment on attachment 271884 [details]
> Patch
> 
> I don't think the current approach is good because we would like to assume
> that there is an empty `arguments` if the CLI does not pass any arguments.
> 
> How about the following idea?
> 1. adding an Option (see runtime/Options.h), that controls exposing the
> `arguments`. Now, we can control this behavior with the environment variable
> JSC_XXX (If you add an option XXX, we can switch it with the environment
> variable JSC_XXX)
> 3. adding a ruby function notExposeArguments() in run-jsc-stress-tests,
> which defines JSC_XXX environment variable before executing the command.
> (Let's define addEnvVar(X, Y). And calling it as def notExposeArguments
> addEnvVar("JSC_XXX", "true"))
> 4. defining the annotation "//@ notExposeArguments" instead of "//@ skip"

Problem is that I use run-layout-jsc, which does not support annotations, and my initial motivation for this change was to allow this test to pass without @ skip annotation.

Though run-layout-jsc may unconditionally use this mode.

[Geoffrey Garen]

Comment on attachment 271884 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 271884 [details]
Patch

Clearing flags on attachment: 271884

Committed r196948: <http://trac.webkit.org/changeset/196948>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.