Bug 154513 - Re-sync W3C HTML/DOM web-platform-tests
Summary: Re-sync W3C HTML/DOM web-platform-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 154502
  Show dependency tree / graph
 
Reported: 2016-02-21 09:53 PST by Chris Dumez
Modified: 2016-02-26 00:13 PST (History)
7 users (show)

See Also:

Attachments
Patch (41.01 KB, patch)
2016-02-21 10:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (48.32 KB, patch)
2016-02-21 13:03 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-21 09:53:22 PST 
Re-sync W3C HTML/DOM web-platform-tests after:
https://github.com/w3c/web-platform-tests/pull/2597
Comment 1 Chris Dumez 2016-02-21 10:39:08 PST 
Created attachment 271883 [details]
Patch
Comment 2 Chris Dumez 2016-02-21 13:03:52 PST 
Created attachment 271886 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-21 17:27:39 PST 
Comment on attachment 271886 [details]
Patch

Clearing flags on attachment: 271886

Committed r196883: <http://trac.webkit.org/changeset/196883>
Comment 4 WebKit Commit Bot 2016-02-21 17:27:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 youenn fablet 2016-02-24 12:52:13 PST 
I plan to resync all wpt tests.
Did you use 5a2e4eb7c92bfa91e00465ec1f2922ec3412829a for the html tests?
Comment 6 Chris Dumez 2016-02-24 12:53:54 PST 
(In reply to comment #5)
> I plan to resync all wpt tests.
> Did you use 5a2e4eb7c92bfa91e00465ec1f2922ec3412829a for the html tests?

I have been updating tests in a very ad-hoc fashion over the last few weeks, simply by copying tests over from the other repo. I do not know which exact revision I used when I last did a full sync and some of the tests have been updated more recently than that.
Comment 7 youenn fablet 2016-02-26 00:13:21 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > I plan to resync all wpt tests.
> > Did you use 5a2e4eb7c92bfa91e00465ec1f2922ec3412829a for the html tests?
> 
> I have been updating tests in a very ad-hoc fashion over the last few weeks,
> simply by copying tests over from the other repo. I do not know which exact
> revision I used when I last did a full sync and some of the tests have been
> updated more recently than that.

I see.

If you are not using the importer, it might be good to check and update LayoutTests/imported/w3c/resources/ImportExpectations, which defines which tests the importer will skip. That way, this will ensure that when resyncing the whole test suite, some added tests do not get removed inadvertently.

The issue remains for tests specific to WebKit and not yet upstreamed to WPT repo. The importer should probably only remove tests that were removed between the old and new revision of the WPT repo.