RESOLVED FIXED 154508
Web Inspector: it should be possible to omit generated code guarded by INSPECTOR_ALTERNATE_DISPATCHERS 
https://bugs.webkit.org/show_bug.cgi?id=154508
Summary Web Inspector: it should be possible to omit generated code guarded by INSPEC...
Blaze Burg
Reported 2016-02-20 22:37:03 PST
patch coming.
Attachments
Proposed Fix (21.04 KB, patch)
2016-02-20 22:51 PST, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-02-20 22:37:19 PST
<rdar://problem/24759077>
Blaze Burg
Comment 2 2016-02-20 22:51:23 PST
Created attachment 271876 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-02-20 22:52:47 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2016-02-20 22:52:55 PST
Attachment 271876 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:70: [CppBackendDispatcherHeaderGenerator.generate_output] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:205: [CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain] Instance of 'CppBackendDispatcherHeaderGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:59: [CppBackendDispatcherImplementationGenerator.generate_output] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:281: [CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command] Instance of 'CppBackendDispatcherImplementationGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 4 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 5 2016-02-21 16:08:35 PST
Committed r196881: <http://trac.webkit.org/changeset/196881>
Note You need to log in before you can comment on or make changes to this bug.